Hey,

Damien Carbery wrote:
> Last week I was building some SFE packages. It turns out that when SFEguile 
> is installed, the aisleriot game (in gnome-games) is built.
> The code below includes the aisleriot files when SFEguile is installed:
> 
> --- SUNWgnome-games.spec        (revision 10519)
> +++ SUNWgnome-games.spec        (revision 10521)
> @@ -13,6 +13,8 @@
>  
>  %define makeinstall make install DESTDIR=$RPM_BUILD_ROOT
>  %use gnome_games = gnome-games.spec
> +# The Aisleriot game is built if SFEguile is installed.
> +%define with_guile %(pkginfo -q SFEguile && echo 1 || echo 0)

I don't believe we should be introducing dependencies into the build system on
the SFE packages - I know it's an optional dependency, but I'd prefer we check
against a system installed package or something. Other than that, perhaps being
able to add a --disable check in the configure is an option.


Glynn

Reply via email to