Ah I apologise for not making this clear in my review mail. In both the bugster and bugzilla bugs I noted that this is definitely not the best way to do this and that we would have to come up with a better way to determine the DVD support in cdrecord.
I hoped to stir up some ideas via bugzilla or here so thanks. I'm not sure about using AC_PATH_PROG for cdrecord-pro since I believe some distros ship unofficial DVD support in cdrecord without changing the binary name. e.g. Fedora Core 2. Also on Solaris we have no cdrecord-pro binary/link. I looked at using cdrecord -version output but thats not fool proof either. Any more ideas? Stephen. On Mon, 2007-04-02 at 22:40 +0100, Alvaro Lopez Ortega wrote: > Stephen Browne wrote, On 02/04/07 13:37: > > > Solaris cdrecord-ProDVD DOES support dvd burning for all users ... > > > > +case "$host" in > > +*solaris*) > > + AC_DEFINE(CDRECORD_SUPPORTS_DVD,1,Define to 1 if solaris) > > + ;; > > +esac > > If we want to submit the patch upstream, wouldn't it be better to > take the OS independent way? > > Solaris supports growisofs as Linux supports cdrecord-pro, so IMO it > would be better if we do not suppose a certain program set on each > platform. > > We could use AC_PATH_PROG to detect cdrecord-pro. >
