Hi Ghee,
The patch looks fine to me.
Erwann
Ghee Teo wrote:
> Metacity core dump in TJDS as of vermillion devel. This is triggerred
> by the setting of
> G_DEBUG=fatal_critical. As it turned out, the metacity code is n.ot
> initializing some code
> properly. The problem is that shaded_styles is a double array, but the
> code just referencing a single array.
>
>
> This patch fixes the problem, though would like Erwann to look at this.
>
> *--- SUNWgnome-wm-2.18.0.hacked/metacity-2.18.0/src/theme.c
> 2007-04-03 16:26:13.442910000 +0000*
> *+++ SUNWgnome-wm-2.18.0.built/metacity-2.18.0/src/theme.c
> 2007-04-03 16:07:53.317693000 +0000*
> *@@ -4666,12 +4666,12 @@*
> * {*
> * set_trusted_ops(sset->normal_styles[i][META_FRAME_FOCUS_YES],
> META_FRAME_FOCUS_YES);*
> * set_trusted_ops(sset->normal_styles[i][META_FRAME_FOCUS_NO],
> META_FRAME_FOCUS_NO);*
> *+ set_trusted_ops(sset->shaded_styles[i][META_FRAME_FOCUS_YES],
> META_FRAME_FOCUS_YES);*
> *+ set_trusted_ops(sset->shaded_styles[i][META_FRAME_FOCUS_NO],
> META_FRAME_FOCUS_NO);*
> * }*
> * *
> * set_trusted_ops(sset->maximized_styles[META_FRAME_FOCUS_YES],
> META_FRAME_FOCUS_YES);*
> * set_trusted_ops(sset->maximized_styles[META_FRAME_FOCUS_NO],
> META_FRAME_FOCUS_NO);*
> *- set_trusted_ops(sset->shaded_styles[META_FRAME_FOCUS_YES],
> META_FRAME_FOCUS_YES);*
> *- set_trusted_ops(sset->shaded_styles[META_FRAME_FOCUS_NO],
> META_FRAME_FOCUS_NO);*
> *
> set_trusted_ops(sset->maximized_and_shaded_styles[META_FRAME_FOCUS_YES],
> META_FRAME_FOCUS_YES);*
> *
> set_trusted_ops(sset->maximized_and_shaded_styles[META_FRAME_FOCUS_NO],
> META_FRAME_FOCUS_NO);*
> * }*
>
--
Erwann Ch?ned?,
Desktop Group, Sun Microsystems, Grenoble
Phone : +33 476 188 358 ext: 38358
[ I speak for myself, not for my employer ]
