Dermot,
Sorry about the slow response. Some comments below.
On Tue, 2006-12-12 at 12:01 +0000, Dermot McCluskey wrote:
> Three new files for new pkg SUNWvirt-manager, the Virtual
> Machine Manager, used for controlling Xen (and possibly
> other) virtual machines.
>
> virt-manager.spec
> Solaris/SUNWvirt-manager.spec
> patches/virt-manager-01-build-flags.diff
> #
> # spec file for package SUNWvirt-manager
> #
> # includes module(s): virt-manager
> #
> # Copyright (c) 2006 Sun Microsystems, Inc.
> # This file and all modifications and additions to the pristine
> # package are under the same license as the package itself.
> #
> # Owner: dermotm
> #
> %include Solaris.inc
>
> %use virtmanager = virt-manager.spec
>
> Name: SUNWvirt-manager
> Summary: Virtual Machine Manager
> Version: %{virtmanager.version}
> SUNW_BaseDir: %{_basedir}
> BuildRoot: %{_tmppath}/%{name}-%{version}-build
>
> # date:2006-12-08 owner:dermotm type:bug
> Patch1: virt-manager-01-build-flags.diff
Patches should always be added in the Linux spec file.
> # need to change these?
> %{_prefix}/etc/gconf/schemas/virt-manager.schemas
This will need to be installed via a postrun script, see
spec-files/docs/gconf.txt
> %{_prefix}/libexec/virt-manager-launch
We don't use /usr/libexec on Solaris, add --libexecdir=%{_libexecdir}
in the Linux spec file, that will move this to /usr/lib.
> --- virt-manager-0.2.6-old/src/graphWidgets/Makefile.am Fri Dec 8
> 16:56:18 2006
> +++ virt-manager-0.2.6/src/graphWidgets/Makefile.am Fri Dec 8
> 16:56:53 2006
> @@ -24,7 +24,7 @@
> sparkline.c \
> sparkline.h
>
> -sparkline_la_CFLAGS = -fPIC -Wall \
> +sparkline_la_CFLAGS = -KPIC \
> -DUSE_CAIRO=1 \
> $(PYGTK2_CFLAGS) \
> $(GTK2_CFLAGS) \
This is not the right way to fix this as you are changing a gcc specific
thing to a Forte specific thing.
The correct fix is setting these flags conditionally, in configure.in.
You can use the $GCC variable to check is the compiler is gcc.
See glib2's configure.in for an example.
Laca
