Hi Halton, Thanks for the review. The attached spec has been updated. One comment below:
Halton Huo wrote: >> Name: SUNWgftp >> Summary: gFTP - Multithreaded FTP client for *NIX >> based machines >> URL: http://gftp.seul.org/ >> Version: 2.0.18 >> > Please specify License with exact version number. In your case, > License: GPL v2 > > >> # date:2008-09-23 owner:alfred type:up-streamed >> Patch1: gftp-01-solaris-in-trunk.diff >> >> > wrong type here, should be: > # date:2008-09-23 owner:alfred type:bug state:upstream > > And you need add bugdb info in header, please refer to > http://www.opensolaris.org/os/project/jds/documents/patch_comments/ > The patch comes from the gFTP's trunk code to fix an error on Solaris. If the community releases a newer version, it should be in it. Do I need to figure out which bug fix this issue? Thanks, -Alfred >> %build >> ./configure --prefix=%{_prefix} --mandir=%{_prefix}/share/man >> > Use ./configure --prefix=%{_prefix} --mandir=%{_mandir} > > >> %files >> %defattr(-, root, bin) >> %doc README ChangeLog COPYING INSTALL >> > According your copyright file, you use bzip2 for them. So here should > be: > %doc(bzip2) README ChangeLog COPYING INSTALL > > > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: SUNWgftp.spec URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20081113/51b22097/attachment.ksh>
