Jedy:

> The attached patch is the fix to CR6717883-problem 3 in "Evluation"
> section. The fix includes 3 parts:
> 1) Remove the call to xsetroot in /etc/X11/gdm/PreSession/Default.

This is fine.

> 2) In /usr/share/gdm/default.conf, tell gdmgreeter the background is a
> image and the image is /usr/share/pixmaps/splash/indiana-splash.jpg.

If we change default.conf, we should change it in the two gdm-01
patches, not in separate patches.  The idea of the gdm-01 patch is
that is where all changes to default.conf goes.

> 3) In gui/greeter/greeter.c, add the code to scale the image and show it
> as the background.

Why not modify the code so that if BackgroundType=1 that it calls
setup_background and otherwise it calls 
gdm_common_setup_background_color if GDM_KEY_GRAPHICAL_THEMED_COLOR
is not empty?

This change could go upstream, I think.

Brian

Reply via email to