Willie: I'd think we should be migrating this spec file from spec-files-extra and into spec-files or spec-files-other. I'd recommend spec-files-other unless espeak is from the GNOME consolidation (e.g. served at the GNOME FTP servers).
I'd expect the spec-file and package name to change from SFEespeak to SUNWespeak. Also should make sure that the License, URL, and other standard keys are defined. You can look at any spec-file in the spec-files module to see what the header section should contain. Some spec files in SFE don't specify all the fields, like mainly License and URL. Anyway, when you go through this exercise, you will notice that most other spec-files contain a Copyright notice, which refers to a file that we keep in the spec-files/copyright directory. Note that Laca has a tool called spec-files/copyright-extractor. You need to run this program on eSpeak and build the copyright file for this module. We can do the work together, so if you provide me with the output of the above script, I'll help you reformat the output as needed. Aside from fixing the name from SFE to SUNW, I think the spec-files are ready to be put back to SVN. The additional work, like the copyright stuff, can be done after it the spec-file is integrated. Brian > As part of the process to incorporate eSpeak into OpenSolaris, it was > requested that eSpeak be ported to SunStudio from gcc. This had an > impact on building the gnome-speech driver for espeak, requiring the > gnome-speech build to explicitly add SunStudio libraries to the build. > > Attached are two patches: > > * sfe-espeak.diff: changes to the spec-files-extra area to build eSpeak > with SunStudio. Laca has reviewed these and approved me to check them > in. Since they end up requiring changes to SUNWgnome-a11y-speech, > however, I will hold off on checking these in until the > SUNWgnome-a11y-speech changes (the subject of this review request) are > approved. > > * jds-gnome-speech-espeak.diff: the subject of this review request. > These changes add the -lCstd -lCrun -lm libraries to the build of the > gnome-speech driver for eSpeak. Laca has also reviewed these. > > Please review these and let me know if/when I can commit. > > Thanks! > > Will
