Hi, Stephen Browne wrote: > Hi Glynn, > > I think that this is a good example of the information people should be > providing in a review request. Others should follow a similar format. > > Is this bug so critical that it requires a patch in JDS SVN before the > fix has been accepted in the master source?
No, it was really just an excuse to start the ball rolling with the review mechanism to and encourage others that bug fixing is worthwhile at the moment since it's the perfect opportunity to get patches upstream for both the 2.16 macro releases, along with HEAD. > You only opened the bugzilla bug today and it is still open. > Granted it does look like your fix will be accepted but is it possible > we can live without this fix until a new source tarball is avilable? > In this case there would be no need for a patch and no need for a review > here. If not, would it not still be better to wait until your fix has > been accpeted before adding another JDS SVN patch? Yeah, I should have done this. Glynn
