For the record...
On Thu, 2006-11-02 at 15:42 +0000, Damien Carbery wrote:
> http://bt2ws.central.sun.com/CrPrint?id=6488895
> invest-chart in build (Launch/All Applications/Office), it should not be
> included as it is not in the UI spec.
>
> The patch simply removes the files during the %install section.
> This is being sent for review in case anyone feels strongly that the app
> should be in the UI spec.
[09:55] <damienc> laca: the invest-chart change was trivial.
[09:55] <laca> i know, but i disagree with it
[09:55] <damienc> Bug 6488895 says that it isn't in the UI spec.
[09:55] <damienc> ok, I'll put it out for review.
[09:56] <laca> i think it's a harmless little thing
[09:56] <damienc> agreed
[09:56] <laca> maybe it should be in /usr/demo/jds
[09:56] <laca> are we gonna delete all new additions to the gnome pkgs
that are not in the ui spec or should we update the ui spec
instead?
[09:57] <damienc> I would hope for the latter, but the former is more
likely.
[09:57] * damienc loves using 'former' and 'latter'
[09:57] <damienc> calumb: what's your take on such things?
[09:59] <calumb> damienc: all UI spec changes have to go through cteam
now that it's 'stable'... I'm composing an email to them now
with some changes, I can add that one if you like (but
personally I'd rather it wasn't there)
[09:59] <calumb> damienc: oh, and I'm the only person who's allowed to
update the spec :)
[09:59] <damienc> why do you not like it?
[10:03] <calumb> damienc: IIRC it's really an applet/panel thing, no?
(It doesn't do anything when I run it, so I can't check...) If
so, it belongs somewhere in the other applet/panel menus...
[10:03] <damienc> I think it is for Yahoo investment/stock charts
[10:03] <calumb> damienc: plus why should we be promoting Yahoo stuff
on our desktop...?
[10:04] <calumb> damienc: we can just add some default bookmarks to
their website if we like 'em that much :)
[10:05] <calumb> s/to/for
[10:05] <damienc> laca: since calumb is not moving, is the review still
useful? ;)
[10:06] <calumb> I just don't understand why it's on the launch menu, in
Ubuntu it's in the 'add to panel' menu, where it should be...
[10:07] <laca> see, i would have preferred this conversation on
jds-review so that it's archived
[10:07] <damienc> sorry, it is in 'add to panel'
[10:07] <calumb> It's on my Launch menu...
[10:07] <damienc> really?
[10:07] <calumb> in Office category...
[10:07] * damienc looks at bug again
[10:07] <damienc> ah, you're right.
[10:07] <laca> yeah, it's there
[10:08] <damienc> so, removing the .desktop file might be enough to fix
the bug
[10:08] <damienc> but leave the 'add to panel' bit
[10:08] <damienc> or does 'add to panel' need a .desktop file with it?
[10:09] <calumb> damienc: no, applets just need an omf file IIRC
[10:10] <Stephen> .server file
[10:10] <calumb> (I'm happy to suggest to the c-team that it stays in
the 'add to panel' menu, as that's not in the UI spec either...)
[10:10] <Stephen> OMF is old help wotnot
[10:10] <calumb> Stephen: oh yeah, that's the one
[10:10] <laca> btw, one is invest-applet the other is invest-chart
[10:10] * damienc should read the bug more carefully.
[10:10] <laca> invest-applet is a bit like the old stock ticker thingie
[10:11] <calumb> laca: hmm, so it is... what does invest-chart do then?
(nothing, on my machine...)
[10:11] <laca> invest-chart is a python script that displays yahoo
finance charts of the stock symbol of your choice
[10:11] <laca> it works for me
[10:12] <damienc> laca: I'll fix my commit (to put invest-applet back in
packages)
[10:12] <calumb> laca: displays them where?
[10:12] <damienc> and send 'invest-chart' change to jds-review
[10:12] * laca sends as screenshot to calumb
[10:12] * calumb wonders how you can choose stocks from the launch menu
[10:12] <calumb> laca: thx
[10:14] <laca> sent
[10:15] <calumb> laca: got it... just gives python errors on my machine
(running from command line)
[10:15] <laca> weird
[10:15] <damienc> anything we should be concerned about? e.g. missing
modules?
[10:15] <laca> what are python errors?
[10:15] <calumb> does seem a bit over-reliant on Yahoo though,
especially as they've just completely changed all their chart
stuff
[10:16] <calumb> Data Dir: /usr/share/gnome-applets/invest-applet
[10:16] <calumb> Traceback (most recent call last):
[10:16] <calumb> File "/usr/bin/invest-chart", line 3, in ?
[10:16] <calumb> import sys, invest.chart, gtk
[10:16] <calumb> File "/usr/lib/python2.4/site-packages/invest/chart.py",
line 5, in ?
[10:16] <calumb> import egg.trayicon
[10:16] <calumb> ImportError: No module named egg.trayicon
[10:18] <laca> oh, heh, yeah
[10:18] <laca> i works for me cause i have an extra python pkg installed
[10:18] <laca> gnome-python-extras
[10:18] <laca> which it requires
[10:18] <calumb> d'oh
[10:19] <laca> i wrote a spec file on June 26 but apparently never put
it back to svn
[10:21] <calumb> ah... well, now that I see things aren't quite as bad
as I thought they were, I'm happy to ask the c-team if they want
to keep them around...
