Ghee Teo wrote: > Is removal of a patch like this necessary for a review?
I don't know. I thought I would err on the side of caution. > Or does this provide the data we need for analysis? > Probably not. The reason for the patch is discussed in http://bugzilla.gnome.org/show_bug.cgi?id=336359. The reason for the removal is that gok no longer uses the functions which the patch allowed to be exported. Padraig > -Ghee > > Padraig O'Briain wrote: >> This is a change to remove the patch at-spi-01-define-symbols.diff as >> it is no longer needed. >> >> Padraig >> ------------------------------------------------------------------------ >> >> Index: ChangeLog >> =================================================================== >> --- ChangeLog (revision 9682) >> +++ ChangeLog (working copy) >> @@ -1,3 +1,9 @@ >> +2006-11-08 Padraig O'Briain <padraig.obriain at sun.com> >> + >> + * at-spi.spec: Updated for patch removal >> + * patches/at-spi-01-define-symbols.diff: removed >> + * patches/at-spi-02-fix-leaks.diff: renamed >> + >> 2006-11-07 Brian Cameron <brian.cameron at sun.com> >> >> * patch/gdm-07-linguas.diff: Add Serbian and Montenegro >> languages. >> Index: at-spi.spec >> =================================================================== >> --- at-spi.spec (revision 9682) >> +++ at-spi.spec (working copy) >> @@ -16,9 +16,8 @@ >> Source: >> http://ftp.gnome.org/pub/GNOME/sources/at-spi/1.7/%{name}-%{version}.tar.bz2 >> >> Source1: at-spi.3.gz >> Source2: libcspi.3.gz >> -Patch1: at-spi-01-define-symbols.diff >> #owner:padraig date:2006-11-07 type:bug bugster:6457388 >> bugzilla:361386/369377 >> -Patch2: at-spi-02-fix-leak.diff >> +Patch1: at-spi-01-fix-leak.diff >> URL: http://developer.gnome.org/projects/gap/ >> BuildRoot: %{_tmppath}/%{name}-%{version}-build >> Docdir: %{_defaultdocdir}/%{name} >> @@ -59,7 +58,6 @@ >> %prep >> %setup -q >> %patch1 -p1 >> -%patch2 -p1 >> >> >> %build >> @@ -129,6 +127,9 @@ >> %{_mandir}/man3/* >> >> %changelog >> +* Wed Nov 8 2006 - padraig.obriain at sun.com >> +- Remove patch 01-define-symbols.diff; move patch 02-fix-leak.diff to >> + 01-fix-leak.diff >> * Fri Nov 3 2006 - laca at sun.com >> - use %gtk_doc_option in configure so that it can be disabled using >> --without-gtk-doc >> >
