Ghee: I will work with Artem to update D-Bus to 1.0.1. This will involve providing Artem with packages for testing, and once we get a thumbs-up from him, we can decide how we want to integrate into JDS and Nevada.
Brian > The bugster id is 6488534, bugzilla id is > https://bugs.freedesktop.org/show_bug.cgi?id=5899 > The fix is to do a sanity check on the value it passed in > find_name_in_info(). Acoording > to bugzilla, this has been fixed in a later release, not sure which. > > The fix is uninteresting, but I attached this patch for review because > I think the following > is more important. > we have dbus 0.61 in our current build and the community has just > released 1.0! > I downloaded 1.0 tarball, the code base is so different. The file it > patches doesnot > even exists. So we can remove this patch when we update later. > > But who own the update version of dbus? > > > -Ghee > > > ------------------------------------------------------------------------ > > Index: patches/dbus-06-proxy-change-owner-crash.diff > =================================================================== > --- patches/dbus-06-proxy-change-owner-crash.diff (revision 0) > +++ patches/dbus-06-proxy-change-owner-crash.diff (revision 0) > @@ -0,0 +1,12 @@ > +diff -urN dbus-0.62/glib/dbus-gproxy.c > ../SUNWdbus-0.62.hacked/dbus-0.62/glib/dbus-gproxy.c > +--- dbus-0.62/glib/dbus-gproxy.c 2006-04-30 10:45:41.000000000 +0000 > ++++ ../SUNWdbus-0.62.hacked/dbus-0.62/glib/dbus-gproxy.c 2006-11-17 > 16:03:35.319439000 +0000 > +@@ -493,6 +493,8 @@ > + const DBusGProxyNameOwnerInfo *info = a; > + const char *name = b; > + > ++ if (info == NULL || info->name == NULL) > ++ return 1; > + return strcmp (info->name, name); > + } > + > Index: dbus.spec > =================================================================== > --- dbus.spec (revision 9760) > +++ dbus.spec (working copy) > @@ -22,6 +22,8 @@ > Patch3: dbus-03-dbus-launch.diff > Patch4: dbus-04-libexec.diff > Patch5: dbus-05-priv.diff > +#owner:gheet bugster:6488534 bugzilla:5899 type:bug > +Patch6: dbus-06-proxy-change-owner-crash.diff > BuildRoot: %{_tmppath}/%{name}-%{version}-build > Docdir: %{_defaultdocdir}/doc > Autoreqprov: on > @@ -70,6 +72,7 @@ > %patch3 -p1 > %patch4 -p1 > %patch5 -p1 > +%patch6 -p1 > %endif > > %build > @@ -133,6 +136,10 @@ > %{_libdir}/python?.?/vendor-packages/* > > %changelog > +* Fri Nov 17 2006 - ghee.teo at sun.com > +- Added patch dbus-06-proxy-change-owner-crash.diff. This patch is only > + for 0.6x release of dbus, when dbus 1.0 is incorporated, this patch > + can be dropped. > * Fri Oct 13 2006 - damien.carbery at sun.com > - Delete .a and .la files. > * Wed Aug 30 2006 - damien.carbery at sun.com
