Hi, Takao:

Nice to see your patch.
I tried it with OpenSolaris, and it works fine with a small fix:

ndirents = scandir (GNOMELOCALEDIR,

should be changed to:

ndirents = scandir (LIBLOCALEDIR,

Besides, Suresh and I prefer to remove locales with modifiers "@" from 
the list.
So I'd like to add below lines:

> 517 char *is_modifier = g_strstr_len (dirents[cnt]->d_name, -1, "@");
> 518
> 519 /* No longer use the short locale names and modifiers by default. */
> 520 if (is_territory == NULL || is_modifier != NULL) {
> 521 continue;
> 522 }
>
What do you think about it?

Best Regards,
Harry Fu

on 2009?08?25? 08:43, Takao Fujiwara wrote:
> Oops, I didn't notice this update yesterday.
> FYI: My update yesterday...
> http://bugzilla-attachments.gnome.org/attachment.cgi?id=141542
>
> (08/24/09 15:20), FU Ning-san wrote:
>> The attached patch fix d.o.o. 10615:
>> [gnome 2.28] New GDM -- Can not login to non-English locales.
>>
>> Best Regards,
>> Harry Fu
>


Reply via email to