Hi Brian, I have already split this two patches. And this one does not include performance improvement. I am trying to upstream the performance patch. After performance patch is committed I will update this patch.
Regards, Jedy On Thu, 2009-09-10 at 12:22 -0500, Brian Cameron wrote: > Jedy: > > > The attached patch fixes bugzilla 583767 - gtk+ should optionally depend > > on medialib (https://bugzilla.gnome.org/show_bug.cgi?id=583767). It also > > removes some removed but un-deleted patches of SUNWgtk2. > > First of all, great work. > > Based on upstream bugzilla bug #583767, it seems like the part > of the patch to improve performance will go upstream, but that > the part of the patch to make GTK+ use dlopen/dlsym will probably > not go upstream. I think we will likely need to maintain the > dlopen/dlsym code as a Solaris-specific patch. > > At the very least, these two issues should probably be treated as > separate issues, with separate upstream bugzilla bugs. > > It would be better, I think to separate this into two patches. > One for the performance improvements, and the other for making > GTK+ use dlopen/dlsym. Since the performance improvements are > more likely to go upstream, I'd say the first patch should be > the performance improvements and the dlopen/dlsym patch should > be based on the code after the performance improvement patch is > applied. > > What do you think? > > Brian
