I notice that when you turn on a11y, xscreensaver displays this error:

   (xscreensaver-lock:16442) GLib-GObject-CRITICAL **: file gobject.c:
   line 1537 assertion 'G_IS_OBJECT (object)' failed

The attached modification fixes the problem.

The problem is in the file driver/lock-Gtk.c.  If a11y is not
enabled, it calls the "make_dialog" function.  If a11y is enabled
it calls the "atk_make_dialog" function.

However, pwd->msg_label was only being set in the "make_dialog"
function.  Since this variable is used in various callback
functions (like the "handle_input" function), it triggers the
error when you are using a11y since pwd->msg_label is NULL.

So, this patch just simply sets pwd->msg_label in the "atk_make_dialog"
function much like it is set in the "make_dialog" function.

Also this patch comments out the "%d LoginHelpers are running" message
which is really just for debug.  This makes xscreensaver look much
nicer when a11y is enabled.

Attached please find the minor modifications to the
xscreensaver-07-gtk-lock.diff patch to fix this.

Brian
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xscreen.diff
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20091009/f89f4d7b/attachment.ksh>

Reply via email to