[ 
https://issues.apache.org/jira/browse/JENA-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010135#comment-13010135
 ] 

Thorsten Möller commented on JENA-50:
-------------------------------------

Nice. Thanks!

However, with the new additional no-op check at the very beginning of the 
method a NPE is thrown if 'old' represents a blank node (URI == null). Please, 
do either

(if making an anon resource named does not make sense)
- add a @throws NPE statement to the JavaDoc to document the behavior if 
invoked with an anon resource,
- add an additional check possibly throwing an Ill'Arg'Ex' if 'old' is anon, or

(if making an anon resource named is a reasonable use case)
- revise the method such that it allows making anon resources named.


> com.hp.hpl.jena.util.ResourceUtils.renameResource(Resource, String) rebinds 
> Graph even if no changes were made
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: JENA-50
>                 URL: https://issues.apache.org/jira/browse/JENA-50
>             Project: Jena
>          Issue Type: Bug
>          Components: Jena
>         Environment: all
>            Reporter: Thorsten Möller
>            Assignee: christopher james dollin
>            Priority: Minor
>         Attachments: Jena.patch
>
>
> This issue directly goes back to the following patch
> http://sourceforge.net/tracker/index.php?func=detail&aid=3046428&group_id=40417&atid=430290
> The underlying Graph is rebound even in (rare) cases where the Graph is 
> actually not modified by the method (e.g., there is a Resource to be renamed 
> but there is actually no triple in the model that involves it).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to