Great, thanks - I'll look and incorporate it ASAP. If there are any questions, I'll ask on the JIRA (JIRA comments are also sent to the developers list).

        Andy

On 10/11/11 22:20, Robert Vesse wrote:
I now have this support working and configurable using a --from switch on the 
command line or ARQ.setContext(Fuseki.enableFromClauses, true) 
programmatically.  I have submitted a patch with some tests for this as 
JENA-162 [1], if this can be reviewed and include in trunk ASAP we'd be 
extremely grateful

Regards,

Rob Vesse

[1]: https://issues.apache.org/jira/browse/JENA-162

-----Original Message-----
From: Robert Vesse [mailto:[email protected]]
Sent: Thursday, November 10, 2011 1:07 PM
To: [email protected]
Subject: RE: Adding FROM/FROM NAMED support to Fuseki?

It works fine with a persistent TDB disk based dataset so I'm going to assume 
the changes work.  I'll write up some test cases over the next few hours and 
then submit the patch to JIRA

Does anyone have a preference whether I make this behavior configurable? i.e. 
add a command line switch which disables FROM/FROM NAMED support or shall I 
leave this up to you guys to decide at a later date?

Cheers,

Rob

-----Original Message-----
From: Andy Seaborne [mailto:[email protected]] On Behalf Of Andy 
Seaborne
Sent: Thursday, November 10, 2011 6:17 AM
To: [email protected]
Subject: Re: Adding FROM/FROM NAMED support to Fuseki?

On 09/11/11 19:16, Robert Vesse wrote:
So following this up further.  I got the 0.2.1-incubating-SNAPSHOT building, 
made my changes to enable FROM/FROM NAMED and ran it locally via Eclipse

I loaded the same data, in the same way using a TDB memory dataset (--mem 
option) like my previous email and still saw the same incorrect behavior, FROM 
clauses do not seem to be respected by TDB

Not quite right. "--mem" creates an ARQ-based in-memory database
unrelated to TDB.  --loc triggers TDB.

Try a small persistent one.

(I haven't tried but --loc="--mem--" may work - it's the name of the
in-memory location)


So what I found was that I did need to also alter decideDataset() so that 
DynamicDatasets.dynamicDataset() will be used to create the dataset and then 
that exhibits the correct behavior.

I will write up some tests for this and then go ahead and submit a patch via 
JIRA if that is ok?

Yes - that's the new workflow.

        Andy


Rob Vesse

Reply via email to