Branch: refs/heads/master
Home: https://github.com/jenkinsci/remoting
Commit: 49c67eef8616c7bc3588263d4ecc2dbcb51d5bb8
https://github.com/jenkinsci/remoting/commit/49c67eef8616c7bc3588263d4ecc2dbcb51d5bb8
Author: Oleg Nenashev <[email protected]>
Date: 2017-11-08 (Wed, 08 Nov 2017)
Changed paths:
M src/findbugs/excludeFilter.xml
M src/main/java/hudson/remoting/AbstractByteArrayCommandTransport.java
M src/main/java/hudson/remoting/Capability.java
M src/main/java/hudson/remoting/Channel.java
M src/main/java/hudson/remoting/ChannelBuilder.java
M src/main/java/hudson/remoting/ChunkedOutputStream.java
M src/main/java/hudson/remoting/ClassLoaderHolder.java
M src/main/java/hudson/remoting/DiagnosedStreamCorruptionException.java
M src/main/java/hudson/remoting/ExportTable.java
M src/main/java/hudson/remoting/FileSystemJarCache.java
M src/main/java/hudson/remoting/InitializeJarCacheMain.java
M src/main/java/hudson/remoting/PipeWindow.java
M src/main/java/hudson/remoting/PreloadJarTask.java
M src/main/java/hudson/remoting/ProxyWriter.java
M src/main/java/hudson/remoting/RemoteClassLoader.java
M src/main/java/hudson/remoting/RemoteInvocationHandler.java
M src/main/java/hudson/remoting/UserRequest.java
M src/main/java/hudson/remoting/Util.java
M src/main/java/hudson/remoting/Which.java
M src/main/java/org/jenkinsci/remoting/engine/JnlpAgentEndpointResolver.java
M src/main/java/org/jenkinsci/remoting/nio/NioChannelHub.java
Log Message:
-----------
[JENKINS-37566] - FindBugs Cleanup. Part #1 (#109)
* [JENKINS-37566] - FindBugs: Unclosed stream in hudson.remoting.Capability
* [JENKINS-37566] - FindBugs: Stream not closed on Exception path in
InitializeJarCacheMain#copyFile
* [JENKINS-37566] - Fix Util#makeResource and remove obsolete hack
* Extra Util#makeResource() polishing
* Deprecate obsolete Util#mkdirs()
* Exceptional case in setLastModifiedTime
* Handle exception case during temp file deletion in FileSystemJarCache
* Synchronize ProxyWriter#closed in write()
* Synchronization of ProxyWriter#channel
* Get rid of the obsolete collection in Channel#properties, fix synchronization
* Checksum#calculateFor() - no need to put if absent since there is a check
above
* UWF_UNWRITTEN_FIELD in ExportTable$Entry
* NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE in JnlpAgentEndpointResolver.
Now we use a more agressive check
* UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR in
org.jenkinsci.remoting.nio.NioChannelHub$NioTransport.abort
* UPM_UNCALLED_PRIVATE_METHOD - hudson.remoting.ChunkedOutputStream.frameSize()
* FindBugs: Revert the stream closure at emoting Capability, just a design to
be reworked
* Unrealistic NP_NULL_ON_SOME_PATH in NioChannelHub
* EI_EXPOSE_REP in DiagnosedStreamCorruptionException (diagnostics code)
* SE_TRANSIENT_FIELD_NOT_RESTORED in PreloadJarTask, RemoteClassLoader,
RemoteInvocationHandler and UserRequest
* Leftover false-positive UG_SYNC_SET_UNSYNC_GET in Channel
* EI_EXPOSE_REP in ChannelBuilder#properties
* Suppress DMI_NONSERIALIZABLE_OBJECT_WRITTEN in ClassLoaderHolder#writeObject()
* Better handling of Streams in hudson.remoting.Capability (still weird)
* Fix the Util#makeResource() behavior for nested folders
* FileSystemJarCache: tmp file may be renamed
* JENKINS-37566 - Modification of Channel#dumpDiagnostics() actually is not
required after the merge of #122
* Disable DP_DO_INSIDE_DO_PRIVILEGED as per feeback from @kohsue in #118
* Fix the FindBugs filter
* [NP_NULL_ON_SOME_PATH] - Prevent NPE in ExportTable#diagnoseInvalidObjectId()
* [RV_RETURN_VALUE_IGNORED_BAD_PRACTICE] - Propagate exceptions when
FileSystemJarCache#retrieve() fails to retrieve the target
* [DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED] - Ignore the warning as per
discussion in #118
* [VO_VOLATILE_INCREMENT] - Suppress warning in Channel#send()
* FindBugs - Which#jarFile() should not suppress all exceptions
* FindBugs - Suppress URF_UNREAD_FIELD in Pipewindow#Real
* [JENKINS-37566] - Channel#properties should be a ConcurrentHashMap
Reason - prevent possible delays and deadlocks in the getter method.
Addresses the feedback from @stephenc
* [JENKINS-37566] - DiagnosedStreamCorruptionException readAhead/readBack
handlers should use a more efficient clone() command
* [JENKINS-37566] - Suppress UG_SYNC_SET_UNSYNC_GET after switching to the
ConcurrentHashMap
* [JENKINS-37566] - hudson.remoting.Util should be tolerant against
InvalidPathException
* [JENKINS-37566] - make ProxyWriter more asynchronous (follow-up to
@stephenc’s review)
* [JENKINS-37566] - Add a comment about race condition as suggested by @stephenc
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
