Branch: refs/heads/release/1.x
Home: https://github.com/jenkinsci/stashnotifier-plugin
Commit: 38e16c36fc7ab1790f400ce16fdffd190c7b01b9
https://github.com/jenkinsci/stashnotifier-plugin/commit/38e16c36fc7ab1790f400ce16fdffd190c7b01b9
Author: Chris Lindee <chris.lin...@cpanel.net>
Date: 2017-12-02 (Sat, 02 Dec 2017)
Changed paths:
M src/main/java/org/jenkinsci/plugins/stashNotifier/StashNotifier.java
M src/test/java/org/jenkinsci/plugins/stashNotifier/StashNotifierTest.java
Log Message:
-----------
Support SHA-1 commit lookup for all runs
When given an AbstractBuild Run, the lookupCommitSha1s() function had the
information for TokenMacro to expand the SHA-1 commits. However, if the
Run was a non-AbstractBuild object, there was not enough information for
TokenMacro to perform expansion (at least, with the parameters originally
provided).
Because of this, warnings were displayed by the StashNotifier step on some
of the runs. Quite often, StashNotifier is one of the last steps of a
build, so the StashNotifier warning was right next to the final message
about a build failure. And since the two "errors" were right next to each
other in the log, new users looking at the Console Output often came to
the incorrect conclusion that StashNotifier was the cause of the error.
Fortunately, TokenMacro has a second function to expandAll macros, one
that works for non-AbstractBuilds. It requires an additional parameter,
but we are given a copy of it in the perform() routine: the workspace. By
passing this parameter down the stack, we can enable token expansion on
all types of Runs.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
