Branch: refs/heads/master
Home: https://github.com/jenkinsci/filesystem_scm-plugin
Commit: 939cc3f0695f52e24961cf81d616c1a18af9acb9
https://github.com/jenkinsci/filesystem_scm-plugin/commit/939cc3f0695f52e24961cf81d616c1a18af9acb9
Author: Jens Rogalli <[email protected]>
Date: 2018-02-17 (Sat, 17 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/RemoteFolderDiff.java
A src/test/java/hudson/plugins/filesystem_scm/FolderDiffFake.java
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
improved method signature of FolderDiff.getNewOrModifiedFiles
Why
- removed explicit testing parameter (antipattern)
what
- solved it be inheritance and overwriting copyFile
Commit: 90d50676716d124f7f9f250272edc350650f1f2d
https://github.com/jenkinsci/filesystem_scm-plugin/commit/90d50676716d124f7f9f250272edc350650f1f2d
Author: Jens Rogalli <[email protected]>
Date: 2018-02-17 (Sat, 17 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
M src/main/java/hudson/plugins/filesystem_scm/RemoteFolderDiff.java
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffFake.java
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
improved signature of FolderDiff.getDeletedFiles
Why
- removed explicit testing parameter (antipattern)
what
- extracted deleteFile()
- solved it be inheritance and overwriting deleteFile
Commit: af8372db9df3a333e7565b54f91769060f291ebd
https://github.com/jenkinsci/filesystem_scm-plugin/commit/af8372db9df3a333e7565b54f91769060f291ebd
Author: Jens Rogalli <[email protected]>
Date: 2018-02-17 (Sat, 17 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/RemoteFolderDiff.java
Log Message:
-----------
Extracted Methods from RemoteFolderDiff.copyFile
why
- better readability
what
- is unix and chmod of destination Folder
Commit: 19f57ef49e43dba54fd176e67b48d02e22869efd
https://github.com/jenkinsci/filesystem_scm-plugin/commit/19f57ef49e43dba54fd176e67b48d02e22869efd
Author: Jens Rogalli <[email protected]>
Date: 2018-02-17 (Sat, 17 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
Log Message:
-----------
extracted getDirFilter
Commit: 1fbb7d547a9ce1049d697fcd5ca96a3145265dac
https://github.com/jenkinsci/filesystem_scm-plugin/commit/1fbb7d547a9ce1049d697fcd5ca96a3145265dac
Author: Jens Rogalli <[email protected]>
Date: 2018-02-17 (Sat, 17 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
Log Message:
-----------
extracted similar code into function
what
- add and Log created
Commit: e2b9084a2f9d0feb48bc3e7e1bdb2a22c6bf6931
https://github.com/jenkinsci/filesystem_scm-plugin/commit/e2b9084a2f9d0feb48bc3e7e1bdb2a22c6bf6931
Author: Jens Rogalli <[email protected]>
Date: 2018-02-18 (Sun, 18 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
Log Message:
-----------
Fixed build errors ( forgot to remove javadoc params)
what
- removed documentation of removed paramteres
- added documentation for parameters which yield a warning when build
Commit: 2935be92ea0f1d373c3b0bc30a7fbc4f1744b3ca
https://github.com/jenkinsci/filesystem_scm-plugin/commit/2935be92ea0f1d373c3b0bc30a7fbc4f1744b3ca
Author: Jens Rogalli <[email protected]>
Date: 2018-02-18 (Sun, 18 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
Refactored Tests
What
- used TemporaryFolder Rule instead explicitly creating and deleting temp folder
- refactored asserting of results
Commit: 1f24903cfcc05251b56548a0bbcdf00f780a8e9a
https://github.com/jenkinsci/filesystem_scm-plugin/commit/1f24903cfcc05251b56548a0bbcdf00f780a8e9a
Author: Jens Rogalli <[email protected]>
Date: 2018-02-18 (Sun, 18 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
extracted createFileAndAddExpectation
Commit: a3a27c7a757e860ab0b9a5d2b1f7e2307a8324fd
https://github.com/jenkinsci/filesystem_scm-plugin/commit/a3a27c7a757e860ab0b9a5d2b1f7e2307a8324fd
Author: Jens Rogalli <[email protected]>
Date: 2018-02-18 (Sun, 18 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
M src/main/java/hudson/plugins/filesystem_scm/RemoteFolderDiff.java
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
renmaed Function
why
- better naming
- removed not used parameter
Commit: 8ea48d2e21f5e286293b84fffc9fe4893914b02a
https://github.com/jenkinsci/filesystem_scm-plugin/commit/8ea48d2e21f5e286293b84fffc9fe4893914b02a
Author: Jens Rogalli <[email protected]>
Date: 2018-02-19 (Mon, 19 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
renamed testcases
why
- to follow pattern functionname_startState_ExpectedOutcome
Commit: 381eb86684a652650f727a809fbd626de6b4eea4
https://github.com/jenkinsci/filesystem_scm-plugin/commit/381eb86684a652650f727a809fbd626de6b4eea4
Author: Jens Rogalli <[email protected]>
Date: 2018-02-19 (Mon, 19 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
refactored Test, extracted similar anonym classes
Commit: ee440808bda33edfa83070a8dde876429377a5d5
https://github.com/jenkinsci/filesystem_scm-plugin/commit/ee440808bda33edfa83070a8dde876429377a5d5
Author: Jens Rogalli <[email protected]>
Date: 2018-02-19 (Mon, 19 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffFake.java
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
renamed process Files and simplified creation off FolderDiffFake
Commit: b9f0a33aa1bf64a8593400dad2c07736dc9151e0
https://github.com/jenkinsci/filesystem_scm-plugin/commit/b9f0a33aa1bf64a8593400dad2c07736dc9151e0
Author: Jens Rogalli <[email protected]>
Date: 2018-02-22 (Thu, 22 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest2.java
A src/test/java/hudson/plugins/filesystem_scm/TestUtils.java
Log Message:
-----------
extracted Test Util Function in own class
Commit: 317f5dc3b965fe421c5de5a57ed6537539c4f672
https://github.com/jenkinsci/filesystem_scm-plugin/commit/317f5dc3b965fe421c5de5a57ed6537539c4f672
Author: Jens Rogalli <[email protected]>
Date: 2018-02-22 (Thu, 22 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
created small Tests to replace old tests
why
- to complex and random test scenarios
- test should be small and repeatable not maybe flaky
what
- started to create new tests to condense them to the essence of the test
Commit: b5aefa28db59ad8157d355d8e9224816faf2a95d
https://github.com/jenkinsci/filesystem_scm-plugin/commit/b5aefa28db59ad8157d355d8e9224816faf2a95d
Author: Jens Rogalli <[email protected]>
Date: 2018-02-22 (Thu, 22 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
Log Message:
-----------
Fixed bug, when dst folder is deleted
Commit: 0563dbbd27e28ebaf586c068f5d47fdd669260bc
https://github.com/jenkinsci/filesystem_scm-plugin/commit/0563dbbd27e28ebaf586c068f5d47fdd669260bc
Author: Jens Rogalli <[email protected]>
Date: 2018-02-22 (Thu, 22 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
fixed bug when src File is deleted, added Test
Commit: 77770186c7aec1a30b0bea2abb9ab9eb503ce045
https://github.com/jenkinsci/filesystem_scm-plugin/commit/77770186c7aec1a30b0bea2abb9ab9eb503ce045
Author: Jens Rogalli <[email protected]>
Date: 2018-02-23 (Fri, 23 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
renmaed old test in old and added new tests
Commit: 5e2ee5dfddeece1205adf68e2d1ae84aac2a704c
https://github.com/jenkinsci/filesystem_scm-plugin/commit/5e2ee5dfddeece1205adf68e2d1ae84aac2a704c
Author: Jens Rogalli <[email protected]>
Date: 2018-02-23 (Fri, 23 Feb 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
Log Message:
-----------
fixed Bug when src directory is not present
Commit: 02053a1c88dee133815f629108c7d0fa6852201c
https://github.com/jenkinsci/filesystem_scm-plugin/commit/02053a1c88dee133815f629108c7d0fa6852201c
Author: Jens Rogalli <[email protected]>
Date: 2018-02-23 (Fri, 23 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
added check that copy and delte are actually executed
Commit: f97b3b6fcc312192d8f0a521f9f3d42d11e1ae40
https://github.com/jenkinsci/filesystem_scm-plugin/commit/f97b3b6fcc312192d8f0a521f9f3d42d11e1ae40
Author: Jens Rogalli <[email protected]>
Date: 2018-02-23 (Fri, 23 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
deleted old tests, have been replaced by new tests
Commit: d62ea46821592ab70d7adc6c9566f76aa9135709
https://github.com/jenkinsci/filesystem_scm-plugin/commit/d62ea46821592ab70d7adc6c9566f76aa9135709
Author: Jens Rogalli <[email protected]>
Date: 2018-02-24 (Sat, 24 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
added Tests for IgnoreHidden Files
Commit: aeb548d34d3bb71ae7703f56a7fa9190b1f61e39
https://github.com/jenkinsci/filesystem_scm-plugin/commit/aeb548d34d3bb71ae7703f56a7fa9190b1f61e39
Author: Jens Rogalli <[email protected]>
Date: 2018-02-24 (Sat, 24 Feb 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
hide File Test added Windows specific code
why
- on nix systems you can hide a file by the name (starts with a dot e.g.
.HiddenFile)
- in windows you need to set explicitly the property
what
- added the setting of this property
Commit: 0e55b17a4d9082cd30eb425b0e501308d254d212
https://github.com/jenkinsci/filesystem_scm-plugin/commit/0e55b17a4d9082cd30eb425b0e501308d254d212
Author: Jens Rogalli <[email protected]>
Date: 2018-03-01 (Thu, 01 Mar 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
Log Message:
-----------
readded the original signatures of methods
why
- better compability to code which uses this plugin
what
- readded old signatures, this time marked as deprecated
Commit: b2e803d9d5c3b835607e2d370dbca88dccb55789
https://github.com/jenkinsci/filesystem_scm-plugin/commit/b2e803d9d5c3b835607e2d370dbca88dccb55789
Author: Jens Rogalli <[email protected]>
Date: 2018-03-04 (Sun, 04 Mar 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
Log Message:
-----------
changed method signature
adjusted method signature
Commit: 3f6bdb78dad8c9eb030e7120673472a7d026a865
https://github.com/jenkinsci/filesystem_scm-plugin/commit/3f6bdb78dad8c9eb030e7120673472a7d026a865
Author: Jens Rogalli <[email protected]>
Date: 2018-03-05 (Mon, 05 Mar 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
M src/main/java/hudson/plugins/filesystem_scm/RemoteFolderDiff.java
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
adjusted to review comments
adjusted Test to changed behaviour
Commit: 31f654857cc72b86d6cc9caac90bf685ba3ee287
https://github.com/jenkinsci/filesystem_scm-plugin/commit/31f654857cc72b86d6cc9caac90bf685ba3ee287
Author: Jens Rogalli <[email protected]>
Date: 2018-03-23 (Fri, 23 Mar 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FSSCM.java
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
Log Message:
-----------
removed buildtime javadoc warnings by adding javadoc
added mentioned and missing javadoc for FSSCM.java and FolderDiff.java
Commit: c676cebc186447879489a35caf11df9ab298383f
https://github.com/jenkinsci/filesystem_scm-plugin/commit/c676cebc186447879489a35caf11df9ab298383f
Author: Jens Rogalli <[email protected]>
Date: 2018-03-24 (Sat, 24 Mar 2018)
Changed paths:
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
Log Message:
-----------
added new line at end fo file
Commit: 0c7667f87d30edb1a5edd526cf5386e0eb0f59da
https://github.com/jenkinsci/filesystem_scm-plugin/commit/0c7667f87d30edb1a5edd526cf5386e0eb0f59da
Author: Oleg Nenashev <[email protected]>
Date: 2018-03-31 (Sat, 31 Mar 2018)
Changed paths:
M src/main/java/hudson/plugins/filesystem_scm/FSSCM.java
M src/main/java/hudson/plugins/filesystem_scm/FolderDiff.java
M src/main/java/hudson/plugins/filesystem_scm/RemoteFolderDiff.java
A src/test/java/hudson/plugins/filesystem_scm/FolderDiffFake.java
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest.java
M src/test/java/hudson/plugins/filesystem_scm/FolderDiffTest2.java
A src/test/java/hudson/plugins/filesystem_scm/TestUtils.java
Log Message:
-----------
Merge pull request #8 from genmad/Refactor_FolderDiff
Refactoring Preperations for Jenkins49561
Compare:
https://github.com/jenkinsci/filesystem_scm-plugin/compare/d735e4f892a8...0c7667f87d30
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
