Branch: refs/heads/master
Home: https://github.com/jenkinsci/vsphere-cloud-plugin
Commit: 9c910d9e1a60c330b104a2a86333606d1314277d
https://github.com/jenkinsci/vsphere-cloud-plugin/commit/9c910d9e1a60c330b104a2a86333606d1314277d
Author: Peter Darton <pjdar...@gmail.com>
Date: 2018-03-27 (Tue, 27 Mar 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/vSphereCloudLauncher.java
M src/main/java/org/jenkinsci/plugins/vSphereCloudSlave.java
M src/main/java/org/jenkinsci/plugins/vSphereCloudSlaveTemplate.java
M
src/main/java/org/jenkinsci/plugins/vsphere/RunOnceCloudRetentionStrategy.java
A src/main/java/org/jenkinsci/plugins/vsphere/VSphereOfflineCause.java
A src/main/resources/org/jenkinsci/plugins/Messages.properties
A src/main/resources/org/jenkinsci/plugins/vsphere/Messages.properties
Log Message:
-----------
Prevent run-once slave from accepting more jobs.
vSphereCloudSlaveTemplate
- now provides each cloud slave it creates with its own
RetentionStrategy instance, being a copy of the template's rather than
being the same instance. This allows us to simplify
RunOnceCloudRetentionStrategy's implementation as it's no longer shared.
RunOnceCloudRetentionStrategy
- can no longer be shared between slaves. It now only holds state
information about one slave. See also: vSphereCloudSlaveTemplate
changes.
- now overrides isAcceptingTasks to prevent further activity instead of
simply setting c.setAcceptingTasks(false).
- now triggers node termination in-line instead of spawning a new
thread for it. We can do this without slowing Jenkins down because our
nodes ask vSphere to delete their VMs in a separate thread. Hopefully
this should fix the re-use bug.
- offline reasons now given as a VSphereOfflineCause that can be
localized. See also: vSphereCloudLauncher changes.
vSphereCloudSlave
- flyweight-task refusal message can now be localized.
- offline reasons now given as a VSphereOfflineCause that can be
localized. See also: vSphereCloudLauncher changes.
vSphereCloudLauncher
- no longer uses the special text "vSphere Plugin" in the offline
reason to recognise our own offline reasons. Our code uses now
VSphereOfflineCause and so we can now use instanceof to detect these
instead of String.contains.
Commit: 620868e4808f0df6772c11331dc86bd3ea8413eb
https://github.com/jenkinsci/vsphere-cloud-plugin/commit/620868e4808f0df6772c11331dc86bd3ea8413eb
Author: Peter Darton <pjdar...@users.noreply.github.com>
Date: 2018-04-04 (Wed, 04 Apr 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/vSphereCloudLauncher.java
M src/main/java/org/jenkinsci/plugins/vSphereCloudSlave.java
M src/main/java/org/jenkinsci/plugins/vSphereCloudSlaveTemplate.java
M
src/main/java/org/jenkinsci/plugins/vsphere/RunOnceCloudRetentionStrategy.java
A src/main/java/org/jenkinsci/plugins/vsphere/VSphereOfflineCause.java
A src/main/resources/org/jenkinsci/plugins/Messages.properties
A src/main/resources/org/jenkinsci/plugins/vsphere/Messages.properties
Log Message:
-----------
Merge pull request #91 from pjdarton/prevent-reuse-of-single-use-slaves
[JENKINS-47821] Prevent run-once slave from accepting more jobs.
Compare:
https://github.com/jenkinsci/vsphere-cloud-plugin/compare/6f78bb0aa164...620868e4808f
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
