Branch: refs/heads/master
Home: https://github.com/jenkinsci/github-branch-source-plugin
Commit: 23021f220393042e66937e65fa328cca6d0f42c5
https://github.com/jenkinsci/github-branch-source-plugin/commit/23021f220393042e66937e65fa328cca6d0f42c5
Author: Stephen Connolly <[email protected]>
Date: 2018-09-21 (Fri, 21 Sep 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
M
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystem.java
M
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
M
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
Log Message:
-----------
Adding some very basic API usage optimizations
- No need to keep revalidating the API URL when it has been known valid
recently (within the last 5 minutes)
- `GitHub.isCredentialsValid()` wastes an API call replicating what
`GitHub.getMyself()` does, only without storing the user object so
that subsequent calls of `GitHub.getMyself()` result in an additional
API call. Rewrote these calls to use `GitHub.getMyself()` so that
we should thus only need to query `https://api.github.com/user`
once per connection object.
- When checking the branches of a repository for a match, always try
the default branch first as that has the highest chance of containing
any marker files and can therefore short-circuit at-least-one checks
Commit: 816192dcec778c1b9e9adab5abddaf0bb20a1ec2
https://github.com/jenkinsci/github-branch-source-plugin/commit/816192dcec778c1b9e9adab5abddaf0bb20a1ec2
Author: Stephen Connolly <[email protected]>
Date: 2018-09-21 (Fri, 21 Sep 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
Log Message:
-----------
Do not release connection objects immediately
- The connection object has some internal cached state, allow for retention of
that state between scans to avoid repeatedly looking up things like user
details, etc.
Commit: 1b3a370d78a4f8b431a55bc79ee795f1d8cece88
https://github.com/jenkinsci/github-branch-source-plugin/commit/1b3a370d78a4f8b431a55bc79ee795f1d8cece88
Author: Stephen Connolly <[email protected]>
Date: 2018-09-21 (Fri, 21 Sep 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
M
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
Log Message:
-----------
Turn back on the on-disk cache.
- For reasons that are lost in the mists of time, the on-disk cache
proved problematic before. I suspect the issue was that the cache
needs to be sharded by credentials as well as api url. We cannot use
the same cache as the GitHub plugin because they use a different
credentials type.
- Defaulting to 20MB and on. Can be disabled by setting the system
property to `0` or using the Groovy console:
`org.jenkinsci.plugins.github_branch_source.GitHubSCMSource.cacheSize`
Commit: 981e39405104941b497e613ef4e4406b86741e3b
https://github.com/jenkinsci/github-branch-source-plugin/commit/981e39405104941b497e613ef4e4406b86741e3b
Author: Stephen Connolly <[email protected]>
Date: 2018-09-21 (Fri, 21 Sep 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
Log Message:
-----------
Findbugs!
Commit: 51c7908c5765e689d28e5d2a8e9a1aa875f26d42
https://github.com/jenkinsci/github-branch-source-plugin/commit/51c7908c5765e689d28e5d2a8e9a1aa875f26d42
Author: Stephen Connolly <[email protected]>
Date: 2018-09-26 (Wed, 26 Sep 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
Log Message:
-----------
Use a consistent salt not a one that is random with every restart
Commit: e7ac121084bcdf1b5959668cea3fb3a22f380686
https://github.com/jenkinsci/github-branch-source-plugin/commit/e7ac121084bcdf1b5959668cea3fb3a22f380686
Author: Stephen Connolly <[email protected]>
Date: 2018-09-28 (Fri, 28 Sep 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
Log Message:
-----------
Experiment: Always force remote validation
- Conditional GET requests only consume API rate counters if they result
in a non-304 response, and this may be the only way to bypass race
conditions inherent with turning on caching (assuming that GitHub
servers actually give us the correct response... but that's why
we have `eventDelaySeconds`... so we should only be checking *after*
GitHub has been given the 5 seconds to get their front-end caches
cleared.)
Commit: 574cb1655880dc971dbb3d4c472907700b49fda9
https://github.com/jenkinsci/github-branch-source-plugin/commit/574cb1655880dc971dbb3d4c472907700b49fda9
Author: Robert Sandell <[email protected]>
Date: 2018-10-02 (Tue, 02 Oct 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
M
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystem.java
M
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
M
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
Log Message:
-----------
Merge pull request #186 from stephenc/basic-api-optimizations
Basic api optimizations
Compare:
https://github.com/jenkinsci/github-branch-source-plugin/compare/e6f8da9b1b6f...574cb1655880
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
