Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: 8109da4573eb818883b87ecbe33983714afab67a
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/8109da4573eb818883b87ecbe33983714afab67a
Author: Eryk Szymanski <eszyman...@collab.net>
Date: 2018-09-13 (Thu, 13 Sep 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/playback/GerritMissedEventsPlaybackManager.java
Log Message:
-----------
Fix the synchronisation block in gerritEvent()
In GerritMissedEventsPlaybackManager there is gerritEvent method
with a block that synchronizes on the receivedEventCache field.
It will get a lock on the referenced object that might be changed
in line 322. That means that the lock might not work as expected.
Running SpotBugs on the class reveals this problem.
Commit: 34313a6e14134b21d6930486e305ab42c09f3b4b
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/34313a6e14134b21d6930486e305ab42c09f3b4b
Author: Robert Sandell <rsand...@cloudbees.com>
Date: 2018-11-02 (Fri, 02 Nov 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/playback/GerritMissedEventsPlaybackManager.java
Log Message:
-----------
Merge pull request #382 from eryksz/fix_synchronisation
Fix the synchronisation block in gerritEvent()
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/d7a303cff7f8...34313a6e1413
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
