Branch: refs/heads/master
Home: https://github.com/jenkinsci/hockeyapp-plugin
Commit: d4849574c82251eccff0db69c977348074efd829
https://github.com/jenkinsci/hockeyapp-plugin/commit/d4849574c82251eccff0db69c977348074efd829
Author: Mez Pahlan <[email protected]>
Date: 2018-11-14 (Wed, 14 Nov 2018)
Changed paths:
M src/main/java/hockeyapp/HockeyappRecorder.java
M src/main/java/net/hockeyapp/jenkins/uploadMethod/VersionCreation.java
M src/test/java/hockeyapp/FreestyleTest.java
M src/test/java/hockeyapp/ProjectTest.java
Log Message:
-----------
[Jenkins-54498] version creation databoundconstructor regression (#56)
* Add Nullable annotation to versionCode
* Remove up unused code
* Move versionCode to optional DataBoundSetter
* Make appId NonNull
* Use CheckForNull for versionCode
Taken from
https://jenkins.io/doc/developer/plugin-development/pipeline-integration/#constructor-vs-setters
* Remove redundant null check
appId is always NonNull.
* Add deprecated constructor
Needed to prevent further breakages as others (such as test classes) may
need it.
* Rename upload version string constant
* Add inline comments
* Update tests for version creation
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
