Branch: refs/heads/master
Home: https://github.com/jenkinsci/nodepool-agents-plugin
Commit: 28791ed3e5ccddce720a77b56db08e751b62adc8
https://github.com/jenkinsci/nodepool-agents-plugin/commit/28791ed3e5ccddce720a77b56db08e751b62adc8
Author: Hugh Saunders <h...@wherenow.org>
Date: 2018-11-30 (Fri, 30 Nov 2018)
Changed paths:
M src/main/java/com/rackspace/jenkins_nodepool/Janitor.java
M src/main/java/com/rackspace/jenkins_nodepool/NodePoolComputer.java
Log Message:
-----------
RE-2230 Cleanup Deadlock
The Janitor thread initiates a clean every 60s. If a node is found that
needs to be cleaned up, a thread is created to clean it up. This thread
waits for the cleanup lock before proceeding. Once the lock is acquired
it does the cleanup, which invovles creating another thread.
The problem is that these cleanup threads can build up, especially
when there are many nodes to remove. If they build up to the near the
thread limit, then deadlock can occur as one thread has the lock, but
it can't create a thread to complete it's task as there are too many
other threads waiting for the lock.
This commit also adds a timeout to a blocking call in
NodepoolComputer.disconnect so that it can't hold the cleanup lock
indefinitely.
Commit: f4d9acb5d367c24a49b643654ca2757f8b975948
https://github.com/jenkinsci/nodepool-agents-plugin/commit/f4d9acb5d367c24a49b643654ca2757f8b975948
Author: Hugh Saunders <h...@wherenow.org>
Date: 2018-11-30 (Fri, 30 Nov 2018)
Changed paths:
M src/main/java/com/rackspace/jenkins_nodepool/Janitor.java
M src/main/java/com/rackspace/jenkins_nodepool/NodePoolComputer.java
Log Message:
-----------
Merge pull request #34 from hughsaunders/RE-2230
RE-2230 Cleanup Deadlock
Compare:
https://github.com/jenkinsci/nodepool-agents-plugin/compare/948e3ef6e8d7...f4d9acb5d367
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
