Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: 9aca3bd12e2effa455ad9eb9e59ae45571330ec1
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/9aca3bd12e2effa455ad9eb9e59ae45571330ec1
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListener.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Added locking around `dynamicGerritProjects`.
In my Jenkins instance, I seemingly randomly have these instances where two
patchset-created events, sent seconds apart, have a problem: one of them
will be processed normally, and the other will not.
After a whole bunch of logging and debugging, I have traced the problem to
the `dynamicGerritProjects` list. On the one that works, the list will be
the proper size; however, on the one that doesn't, it'll be empty.
I suspect that this has to do with the task that updates the dynamic trigger
configuration in the background at the moment when the new event comes in.
Because the timing code is all coordinated by Jenkins, it is at least
plausible that race conditions could be more likely than expected, since
tasks will tend to run at whatever internal intervals Jenkins uses for them.
The logging changes generally add some context to otherwise context-free
log statements.
The locking around `dynamicGerritProjects` aims to control every access of
that variable. For some strange reason, making the lock a normal class member
did not work (it was always null, even when intantiated in the definition as
well as the two constructors). However, using a static constant object seems
to have at least stopped all the null-pointer exceptions.
I'm currently testing this on my instance, and we tend to have this problem
come up once or twice a week. We'll see how it goes.
Commit: 311851e33efb865fb51ec5199775012d46f1e2cd
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/311851e33efb865fb51ec5199775012d46f1e2cd
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Removed a useless log
Commit: 4726f3449936be95f22b53ad5765b0bb76141492
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/4726f3449936be95f22b53ad5765b0bb76141492
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-02-06 (Tue, 06 Feb 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Trigger restarts should not have a bad initial state.
The `start` action here doesn't actually fetch the dynamic project
configuration.
Instead, it starts a thread to do it. This means that there is a window of time
between when `start` returns and when the thread completes its first task that
the
dynamic project list is empty.
For classic use, this was probably not a huge issue. However, using imperative
Jenkinsfile jobs, this is a major problem because after every job is run, the
configuration "changes" (if you use the `properties` command in the job).
In our case, when multiple Gerrit events were submitted in rapid succession,
some
would be "lost" due to the trigger-restart time window where there were no
dynamic
projects listed.
This commit ensures that the dynamic project list is updated as part of the
`start`
action so that the trigger is always valid.
Commit: 45fa17a793f453e8f549ea61696e69f2466bcea0
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/45fa17a793f453e8f549ea61696e69f2466bcea0
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-02-26 (Mon, 26 Feb 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Fixed the logging to use `[]Object{}`
Commit: 9eaccbd2833660fe7c924c943a2adf7740f14cfa
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/9eaccbd2833660fe7c924c943a2adf7740f14cfa
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-02-26 (Mon, 26 Feb 2018)
Changed paths:
M pom.xml
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritServer.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/PluginImpl.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/dependency/BecauseDependentBuildIsBuilding.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/dependency/DependencyQueueTaskDispatcher.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/TriggerContext.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/playback/GerritMissedEventsPlaybackEnabledChecker.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/utils/GerritPluginChecker.java
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritServer/remove.jelly
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/Messages.properties
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/EventListenersReport/index.groovy
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritCause/description.jelly
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly
M src/main/webapp/js/server-table.js
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/LockedDownGerritEventTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/dependency/DependencyQueueTaskDispatcherTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/TriggerContextTest.java
Log Message:
-----------
Merge branch 'master' into dynamic-list-locking
Commit: b77657da0f45c6a21283f5cb558b33996e0315bb
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/b77657da0f45c6a21283f5cb558b33996e0315bb
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-02-28 (Wed, 28 Feb 2018)
Changed paths:
A
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/DynamicConfigurationCacheProxy.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritDynamicUrlProcessor.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimer.java
A
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/DynamicConfigurationCacheProxyTest.java
Log Message:
-----------
Merge branch 'master' into dynamic-list-locking
Commit: ab958ac2842d5f15e14ab201802ba7ab34bb2481
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/ab958ac2842d5f15e14ab201802ba7ab34bb2481
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-08 (Thu, 08 Nov 2018)
Changed paths:
M Jenkinsfile
M build-config/changelog.groovy
M pom.xml
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/Config.java
A
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/Constants.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/BuildMemoryReport.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/Diagnostics.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/support/BuildMemoryComponent.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/job/rest/BuildCompletedRestCommandJob.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/job/rest/BuildStartedRestCommandJob.java
R
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/job/rest/Constants.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritItemListener.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/playback/GerritMissedEventsPlaybackManager.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/utils/GerritPluginChecker.java
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerAction/help-Search.jelly
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerAction/index.jelly
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritProjectListUpdaterFunctionalTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritServerHudsonTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/LockedDownGerritEventTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/api/GerritTriggerApiTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/extensions/GerritTriggeredBuildListenerTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritItemListenerTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerActionApprovalTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/playback/GerritMissedEventsFunctionalTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/BackCompat252HudsonTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/SpecGerritTriggerHudsonTest.java
M
src/test/java/com/sonymobile/tools/gerrit/gerritevents/mock/SshdServerMock.java
Log Message:
-----------
Merge branch 'master' into dynamic-list-locking
Commit: 1709906edc91cc8eee34a316796968c5bbad0f2e
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/1709906edc91cc8eee34a316796968c5bbad0f2e
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-08 (Thu, 08 Nov 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListener.java
A
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventProcessor.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
R
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListenerTest.java
A
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventProcessorTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
Log Message:
-----------
Switch to an event queue
This change makes the EventListener merely listen for events and send
them to the GerritTrigger. The GerritTrigger now has a background thread
called an EventProcessor. When the GerritTrigger receives an event from
the EventListener, it sends the event to the GerritProcessor, which
maintains a queue.
In dynamic configuration mode, the queue is "paused" for reading until
the configuration has been loaded. In non-dynamic configuration mode,
the queue is "unpaused" for reading immediately.
Between stop and start calls, the queue is maintained so that no events
are lost.
Commit: b00cc5b1d3bd457c29cdb46e180236a56a1711d9
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/b00cc5b1d3bd457c29cdb46e180236a56a1711d9
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-16 (Fri, 16 Nov 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListener.java
R
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventProcessor.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
A
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListenerTest.java
R
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventProcessorTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
Log Message:
-----------
Revert "Switch to an event queue"
This reverts commit 1709906edc91cc8eee34a316796968c5bbad0f2e.
Commit: 2643cdf23c6a2f38a8e3c9f19448cada58a6469a
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/2643cdf23c6a2f38a8e3c9f19448cada58a6469a
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-16 (Fri, 16 Nov 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListener.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Use a latch to force EventListener to wait until the project list is ready
The EventListener always "waits" for the project list to be ready before
taking action on an event. For static configurations, this is always
a no-op, since the latch counter will always be zero. For dynamic
configurations, the latch will be initialized to "1" when the trigger
is started; as soon as the configuration has been loaded, it will
decrease to zero.
When the job is updated or repeatedly stopped and started, the latch
will only be reset to "1" if the dynamic configuration URL changes.
This way, things can move smoothly if you're using a pipeline job
that calls "properties()" to reset itself every time.
Commit: 4abc0bd40d70f3f877db8670aadc1847a59bd371
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/4abc0bd40d70f3f877db8670aadc1847a59bd371
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-16 (Fri, 16 Nov 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Default the latch to the "0" state so that the tests are happy.
Commit: d041465bd3002bfb6738bf75cab4e6d9791250be
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/d041465bd3002bfb6738bf75cab4e6d9791250be
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-19 (Mon, 19 Nov 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Fix for line-length warning
Commit: 6bdf25effa3f6f9028fbd169eb5309aed4220f67
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/6bdf25effa3f6f9028fbd169eb5309aed4220f67
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-19 (Mon, 19 Nov 2018)
Changed paths:
M pom.xml
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
The latch is now transient.
This updates the code to make the latch "transient" (it will not be
serialized); instead, we initialize it to the zero state when
`GerritTrigger` is constructed.
Commit: d51668abf292f50a0ea59a14cc83d6ab9caf6ca7
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/d51668abf292f50a0ea59a14cc83d6ab9caf6ca7
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-19 (Mon, 19 Nov 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Make the other new variable transient, as well.
Commit: 600036604d214e2d9488fe6749a0a102cf789b10
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/600036604d214e2d9488fe6749a0a102cf789b10
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-19 (Mon, 19 Nov 2018)
Changed paths:
M pom.xml
Log Message:
-----------
Revert the SureFire workaround.
FYI: -Djdk.net.URLClassPath.disableClassPathURLCheck=true
Commit: c394d5a5d0be8cbdd110a9d13028f198f4e3d338
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/c394d5a5d0be8cbdd110a9d13028f198f4e3d338
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-11-20 (Tue, 20 Nov 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Initialize the latch in `readResolve`
`readResolve` is called when the plugin is loaded from disk, and
this bypasses the constructors (since we don't have a zero-argument
version). In that case, we need to set up the latch appropriately.
I took it out of the constructors because it was redundant, since
it's defined that way at the class level.
I also added some logging for when the different constructor options
are called.
Commit: 2de2c995b091d5a2827a66d7e0c8ad95f308b396
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/2de2c995b091d5a2827a66d7e0c8ad95f308b396
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-12-19 (Wed, 19 Dec 2018)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimer.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
Log Message:
-----------
Added a unit test to cover the dynamic configuration case
Commit: 73fdd4eda79eee5aebf8ceefd23353d86979878f
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/73fdd4eda79eee5aebf8ceefd23353d86979878f
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2018-12-20 (Thu, 20 Dec 2018)
Changed paths:
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
Log Message:
-----------
Move the @PrepareForTest change to just the new test method
Apparently adding `GerritTrigger.class` to `@PrepareForTest` at the
top level breaks things, so I've overridden `@PrepareForTest` at the
method level.
Commit: 04e99b0c5d739d8664b8487b43a7453539ea2f80
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/04e99b0c5d739d8664b8487b43a7453539ea2f80
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2019-02-01 (Fri, 01 Feb 2019)
Changed paths:
M .gitignore
M README.md
M pom.xml
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritServer.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/JenkinsAwareGerritHandler.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/SystemEventThread.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/Config.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/IGerritHudsonTriggerConfig.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/BuildMemoryReport.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/job/rest/BuildCompletedRestCommandJob.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/job/ssh/BuildCompletedCommandJob.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/job/ssh/BuildStartedCommandJob.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/DynamicConfigurationCacheProxy.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimer.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/NewPatchSetInterruption.java
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement/serverStatuses.jelly
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritServer/index.jelly
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritServer/index.properties
M
src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/Messages.properties
A src/main/webapp/help-TriggerOnAllComments.html
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritProjectListUpdaterFunctionalTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritServerHudsonTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/LockedDownGerritEventTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/api/GerritTriggerApiTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/ConfigTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/extensions/GerritTriggeredBuildListenerTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/GerritTriggeredEventComparatorTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerBuildChooserTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/WorkflowTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerActionApprovalTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/TriggerContextParameterizedTriggeredItemEntityTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/TriggerContextTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/MockGerritHudsonTriggerConfig.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/playback/GerritMissedEventsFunctionalTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/playback/GerritMissedEventsLoadPersistTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/BackCompat252HudsonTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/DuplicateGerritListenersHudsonTestCase.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/spec/SpecGerritTriggerHudsonTest.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/utils/MockPluginCheckerConfig.java
M
src/test/java/com/sonymobile/tools/gerrit/gerritevents/mock/SshdServerMock.java
Log Message:
-----------
Merge branch 'master' into dynamic-list-locking
Commit: 6cd2a100ed453878f643994050ff3c3696949bd1
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/6cd2a100ed453878f643994050ff3c3696949bd1
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2019-02-01 (Fri, 01 Feb 2019)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Simplify everything because a stopped instance will never start
Jenkins plugin instances are never "restarted"; instead, they are
just created anew and started from scratch. The new one may be
loaded from storage using `readResolve`, but an existing one will
never be reconfigured directly.
Commit: 5427898dcab2436520e4c20c83676f6626d5f7b9
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/5427898dcab2436520e4c20c83676f6626d5f7b9
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2019-02-01 (Fri, 01 Feb 2019)
Changed paths:
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
Log Message:
-----------
Remove unhelpful comments
Commit: 9363e69e4ff28ddb68d6f0d2f355263e6d97f2ed
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/9363e69e4ff28ddb68d6f0d2f355263e6d97f2ed
Author: Douglas Danger Manley <doug.man...@gmail.com>
Date: 2019-02-08 (Fri, 08 Feb 2019)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
Log Message:
-----------
Removed some unnecessary debug lines
Commit: 6c836a49e0c67e5f766a50f0232d847a172d8a0c
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/6c836a49e0c67e5f766a50f0232d847a172d8a0c
Author: Robert Sandell <rsand...@cloudbees.com>
Date: 2019-02-15 (Fri, 15 Feb 2019)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListener.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimer.java
M
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java
Log Message:
-----------
Merge pull request #350 from tekkamanendless/dynamic-list-locking
Start the trigger in a known state when using a dynamic configuration URL
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/be6e664ceb51...6c836a49e0c6
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
