Branch: refs/heads/master Home: https://github.com/jenkinsci/google-oauth-plugin Commit: d69e66f8154bdce9f29fa9bc89f1ce41d3d10a65 https://github.com/jenkinsci/google-oauth-plugin/commit/d69e66f8154bdce9f29fa9bc89f1ce41d3d10a65 Author: Stephen Shank <stephensh...@google.com> Date: 2019-04-15 (Mon, 15 Apr 2019)
Changed paths: M checkstyleJavaHeader M pom.xml M src/main/java/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentials.java M src/main/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig.java M src/main/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig.java M src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/config.jelly R src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/help-jsonKeyFile.html A src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/help-jsonKeyFileUpload.html M src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/config.jelly R src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/help-p12KeyFile.html A src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/help-p12KeyFileUpload.html A src/test/java/com/google/jenkins/plugins/credentials/oauth/ConfigurationAsCodeTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentialsTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfigTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfigTest.java A src/test/resources/com/google/jenkins/plugins/credentials/oauth/json-service-account-config.yml A src/test/resources/com/google/jenkins/plugins/credentials/oauth/p12-service-account-config.yml A src/test/resources/com/google/jenkins/plugins/credentials/oauth/test-key.json Log Message: ----------- DO NOT MERGE: Add support for JCasC using SecretBytes (#48) * Use DataboundSetter throughout except for final field emailAddress for p12 keys. * Update dependencies required for using JCasC plugin in tests. * Remove unneeded imports. * Add test to verify Configuration as Code behavior, along with associated resources. * Temporarily use old format for license header for checkStyle, because this is based on master and not develop. * Preserve backwards compatibility of json keys. * Preverse compatibility of P12 keys. * Avoid using real keys in any form during JCasC tests. * Address checkstyle failures. * Fix indentation misalignment. Mark dependencies only required for CasC tests as optional so that they are not included when using hpi to package or run. * Remove findbugs dependency. Uses spotbugs from the parent pom since switching to the version that uses spotbugs instead of findbugs is required to use CasC. * Add eof new line to test-key.json * Add missing javadoc on JsonServiceAccountConfig. Use correct capitalization and punctuation in javadoc. * Add TODO tracking issue #50 for deduplication. * Fix secret bytes to account for newline in file. * Incorporate PR feedback. * Fix typos in yml comments. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.