Branch: refs/heads/develop Home: https://github.com/jenkinsci/google-oauth-plugin Commit: 7f357f153b8d6072a9bb2efd911b860aa687c9c8 https://github.com/jenkinsci/google-oauth-plugin/commit/7f357f153b8d6072a9bb2efd911b860aa687c9c8 Author: ikedam <de...@ikedam.jp> Date: 2019-04-15 (Mon, 15 Apr 2019)
Changed paths: M pom.xml M src/main/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig.java M src/main/java/com/google/jenkins/plugins/credentials/oauth/KeyUtils.java M src/main/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig.java M src/main/resources/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentials/config.jelly M src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/config.jelly M src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/config.jelly Log Message: ----------- [FIXED JENKINS-38869] Use SecretBytes to store credentials Commit: c5ae7e20fbbfe262713df120e93ebdba28bec452 https://github.com/jenkinsci/google-oauth-plugin/commit/c5ae7e20fbbfe262713df120e93ebdba28bec452 Author: ikedam <de...@ikedam.jp> Date: 2019-04-15 (Mon, 15 Apr 2019) Changed paths: M src/test/java/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentialsTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfigTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfigTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsTest.java Log Message: ----------- [JENKINS-38869] Update tests to properly work with SecretBytes Commit: 09ef51875db64f6c9240b82ede4dd3899cbcd9a7 https://github.com/jenkinsci/google-oauth-plugin/commit/09ef51875db64f6c9240b82ede4dd3899cbcd9a7 Author: ikedam <de...@ikedam.jp> Date: 2019-04-15 (Mon, 15 Apr 2019) Changed paths: M src/main/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig.java M src/main/java/com/google/jenkins/plugins/credentials/oauth/KeyUtils.java M src/main/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentialsTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfigTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfigTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/RemotableGoogleCredentialsTest.java Log Message: ----------- [JENKINS-38869] Fix styles Commit: d0e854eddbb9d812bd238436f02fb2e08c5218ff https://github.com/jenkinsci/google-oauth-plugin/commit/d0e854eddbb9d812bd238436f02fb2e08c5218ff Author: ikedam <de...@ikedam.jp> Date: 2019-04-15 (Mon, 15 Apr 2019) Changed paths: M pom.xml Log Message: ----------- [JENKINS-38869] Use credentials-2.1.12 so that `SecretBytes` can be used in `DataBoundConstructor` (JENKINS-41946) Commit: 23f48fa6ea5369afc16284c14dcbc052b6842bf1 https://github.com/jenkinsci/google-oauth-plugin/commit/23f48fa6ea5369afc16284c14dcbc052b6842bf1 Author: ikedam <de...@ikedam.jp> Date: 2019-04-15 (Mon, 15 Apr 2019) Changed paths: M src/main/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig.java M src/main/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig.java Log Message: ----------- [JENKINS-38869] Accept invalid configurations in constructors Commit: 6a36812c8a3c9d0569a96a23f5509dc9a194ab98 https://github.com/jenkinsci/google-oauth-plugin/commit/6a36812c8a3c9d0569a96a23f5509dc9a194ab98 Author: ikedam <de...@ikedam.jp> Date: 2019-04-15 (Mon, 15 Apr 2019) Changed paths: M src/test/java/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentialsTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfigTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfigTest.java Log Message: ----------- [JENKINS-38869] Revert tests verifying invalid configurations Commit: 95d1a47c89a7758d04db69e53c04d3468e7e5970 https://github.com/jenkinsci/google-oauth-plugin/commit/95d1a47c89a7758d04db69e53c04d3468e7e5970 Author: ikedam <de...@ikedam.jp> Date: 2019-04-15 (Mon, 15 Apr 2019) Changed paths: M src/main/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig.java Log Message: ----------- [JENKINS-38869] Fix findbug issues adding null check Commit: 85847eb6c4c5c7c107abc6a2c45e00ecdde6ee33 https://github.com/jenkinsci/google-oauth-plugin/commit/85847eb6c4c5c7c107abc6a2c45e00ecdde6ee33 Author: Stephen Shank <stephensh...@google.com> Date: 2019-04-15 (Mon, 15 Apr 2019) Changed paths: M pom.xml M src/main/java/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentials.java M src/main/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig.java M src/main/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig.java M src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/config.jelly R src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/help-jsonKeyFile.html A src/main/resources/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfig/help-jsonKeyFileUpload.html M src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/config.jelly R src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/help-p12KeyFile.html A src/main/resources/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfig/help-p12KeyFileUpload.html A src/test/java/com/google/jenkins/plugins/credentials/oauth/ConfigurationAsCodeTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentialsTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/JsonServiceAccountConfigTest.java M src/test/java/com/google/jenkins/plugins/credentials/oauth/P12ServiceAccountConfigTest.java A src/test/resources/com/google/jenkins/plugins/credentials/oauth/json-service-account-config.yml A src/test/resources/com/google/jenkins/plugins/credentials/oauth/p12-service-account-config.yml A src/test/resources/com/google/jenkins/plugins/credentials/oauth/test-key.json Log Message: ----------- DO NOT MERGE: Add support for JCasC using SecretBytes (#48) * Use DataboundSetter throughout except for final field emailAddress for p12 keys. * Update dependencies required for using JCasC plugin in tests. * Remove unneeded imports. * Add test to verify Configuration as Code behavior, along with associated resources. * Temporarily use old format for license header for checkStyle, because this is based on master and not develop. * Preserve backwards compatibility of json keys. * Preverse compatibility of P12 keys. * Avoid using real keys in any form during JCasC tests. * Address checkstyle failures. * Fix indentation misalignment. Mark dependencies only required for CasC tests as optional so that they are not included when using hpi to package or run. * Remove findbugs dependency. Uses spotbugs from the parent pom since switching to the version that uses spotbugs instead of findbugs is required to use CasC. * Add eof new line to test-key.json * Add missing javadoc on JsonServiceAccountConfig. Use correct capitalization and punctuation in javadoc. * Add TODO tracking issue #50 for deduplication. * Fix secret bytes to account for newline in file. * Incorporate PR feedback. * Fix typos in yml comments. Compare: https://github.com/jenkinsci/google-oauth-plugin/compare/c5ce47ba9ed4...85847eb6c4c5 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.