Branch: refs/heads/master
Home: https://github.com/jenkinsci/basic-branch-build-strategies-plugin
Commit: 35b71cf5101868d15fb16962aa9c3ab082fb7bc4
https://github.com/jenkinsci/basic-branch-build-strategies-plugin/commit/35b71cf5101868d15fb16962aa9c3ab082fb7bc4
Author: Stephen Connolly <[email protected]>
Date: 2019-04-16 (Tue, 16 Apr 2019)
Changed paths:
M
src/main/java/jenkins/branch/buildstrategies/basic/AllBranchBuildStrategyImpl.java
M
src/main/java/jenkins/branch/buildstrategies/basic/AnyBranchBuildStrategyImpl.java
M
src/main/java/jenkins/branch/buildstrategies/basic/NoneBranchBuildStrategyImpl.java
Log Message:
-----------
[JENKINS-56984] Fix layering
- The API is what we expose to external code.
- The SPI is the service provider interface, i.e. what implementations must
provide to the API in order for the API to work
- Thus the only code that is allowed to invoke the SPI is the API code
- These implementations are thus API consumers as well as SPI implementers
- But in this case we have the SPI calling the SPI which prevents the SPI
contract from evolving
- Thus we switch the implementations to call the API of the delegate
implementations
- This does mean that as we evolve the SPI, these 'aggregator' strategies may
obscure features, but it does mean they will not break completely
Commit: dc357e631fdab6dcac76ac821ca21dca5a92c152
https://github.com/jenkinsci/basic-branch-build-strategies-plugin/commit/dc357e631fdab6dcac76ac821ca21dca5a92c152
Author: Stephen Connolly <[email protected]>
Date: 2019-04-16 (Tue, 16 Apr 2019)
Changed paths:
M
src/main/java/jenkins/branch/buildstrategies/basic/AllBranchBuildStrategyImpl.java
M
src/main/java/jenkins/branch/buildstrategies/basic/AnyBranchBuildStrategyImpl.java
M
src/main/java/jenkins/branch/buildstrategies/basic/NoneBranchBuildStrategyImpl.java
Log Message:
-----------
Merge pull request #6 from stephenc/correct-layering
[JENKINS-56984] Fix layering
Compare:
https://github.com/jenkinsci/basic-branch-build-strategies-plugin/compare/5206be12816c...dc357e631fda
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
