Branch: refs/heads/master
Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin
Commit: 826ce8c24eb8bba91ee7b5add9c82afd94ae70ef
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/826ce8c24eb8bba91ee7b5add9c82afd94ae70ef
Author: Pavel Roskin <[email protected]>
Date: 2019-06-25 (Tue, 25 Jun 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java
M
src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java
Log Message:
-----------
Fix handling of failures to fetch the PR list and the PR comments
Add a new exception StashApiException, throw it in both cases.
Don't trigger a build on a failure to fetch PR comments. That issue has
been observed creating a large number of builds if the connection between
Jenkins and Stash is unstable.
Commit: 4f9b7d0c223072fbd715a22d062de8d71aca49bd
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/4f9b7d0c223072fbd715a22d062de8d71aca49bd
Author: Pavel Roskin <[email protected]>
Date: 2019-06-25 (Tue, 25 Jun 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java
Log Message:
-----------
Add @Nonnull annotations, remove unnecessary null checks
In StashApiClient.java, getPullRequests() and getPullRequestComments()
don't return null anymore, they throw StashApiException on error.
extractComments() is used getPullRequestComments() and doesn't return
null either, so annotate it as well.
In StashRepository.java, remove null checks for the results of the
@Nonnull methods.
Compare:
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/2ab923ad3d3f...4f9b7d0c2230
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/2ab923-4f9b7d%40github.com.
For more options, visit https://groups.google.com/d/optout.
