Branch: refs/heads/master
Home: https://github.com/jenkinsci/git-client-plugin
Commit: 5003a75c4353156a43c00e3e05bffa013096895c
https://github.com/jenkinsci/git-client-plugin/commit/5003a75c4353156a43c00e3e05bffa013096895c
Author: René Scheibe <[email protected]>
Date: 2019-12-29 (Sun, 29 Dec 2019)
Changed paths:
M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
Log Message:
-----------
[JENKINS-60316] Fix escaping single quotes in Unix file paths
Points addressed
- a single quote is not allowed between single quotes, even if escaped
- a backslash requires escaping if to be used literally in a reqular expression
This escaping has previously already been used in `quoteUnixCredentials`
which was added in commit 62872bccaf3f0e02c663acfdd85be2b38bddf1e8.
Also see https://www.gnu.org/software/bash/manual/html_node/Single-Quotes.html
Commit: 25b861c8f17ceb9247d789e476298f165c8fe4ee
https://github.com/jenkinsci/git-client-plugin/commit/25b861c8f17ceb9247d789e476298f165c8fe4ee
Author: René Scheibe <[email protected]>
Date: 2019-12-29 (Sun, 29 Dec 2019)
Changed paths:
M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
Log Message:
-----------
Simplify file path escaping
There is no need to
- use regular expressions
- flush the file writer
Commit: 47857f2a47b872866da100952b1a5dffc7ceec50
https://github.com/jenkinsci/git-client-plugin/commit/47857f2a47b872866da100952b1a5dffc7ceec50
Author: Mark Waite <[email protected]>
Date: 2020-01-18 (Sat, 18 Jan 2020)
Changed paths:
M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
Log Message:
-----------
Merge pull request #486 from darxriggs/fix-filepath-quoting
[JENKINS-60316] Fix escaping single quotes in Unix file paths
Duplicated with interactive tests. Automated tests in CredentialsTest
will need to be extended to also test this case.
Did not see the failure on Windows computers before the change
or after the change.
Saw the failure on Linux computers before the change and confirmed
that the Linux computers worked after the change.
Compare:
https://github.com/jenkinsci/git-client-plugin/compare/f94d3241cb28...47857f2a47b8
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/git-client-plugin/push/refs/heads/master/f94d32-47857f%40github.com.
