Branch: refs/heads/feature/JENKINS-62398_make-track-mandatory
  Home:   https://github.com/jenkinsci/google-play-android-publisher-plugin
  Commit: c875dafe3ee79738ba48ffabf672a38cbe7fb804
      
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/c875dafe3ee79738ba48ffabf672a38cbe7fb804
  Author: Christopher Orr <ch...@orr.me.uk>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M 
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher.java
    M 
src/main/resources/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher/config.jelly
    M 
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisherTest.java

  Log Message:
  -----------
  Remove 'production' as the default track name for the upload build step.

This is a breaking change, which will require users to explicitly
provide the track name.

This makes the plugin safer, as publishing to production by default,
e.g. in the absence of configuration, or due to a mistake when defining
a parameter, is probably unexpected behaviour for most users.

It might have been possible to differentiate between a `null` value and
an empty string configured for the `trackName` field, but as we've
changed how this field is interpreted and stored across releases of this
plugin, this wouldn't be reliable.

Better to make this breaking change, and make it clear to all users, old
and new, that they need to specify the track name.


  Commit: 76a26f72ee11a3de2120132600fa3f981633a158
      
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/76a26f72ee11a3de2120132600fa3f981633a158
  Author: Christopher Orr <ch...@orr.me.uk>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M 
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisherTest.java

  Log Message:
  -----------
  Add static imports for helpers in ApkPublisherTest.


  Commit: 3d546a758fa00e71f43a73a788197d1d219ba23d
      
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/3d546a758fa00e71f43a73a788197d1d219ba23d
  Author: Christopher Orr <ch...@orr.me.uk>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M 
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrackAssignmentBuilder.java
    M 
src/main/resources/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrackAssignmentBuilder/config.jelly
    M 
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrackAssignmentBuilderTest.java

  Log Message:
  -----------
  Remove 'production' as the default track name for the move build step.

This is a breaking change, which will require users to explicitly
provide the track name.


  Commit: 22fac28001a7bbb8b76d2ba076ced06d75c2e900
      
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/22fac28001a7bbb8b76d2ba076ced06d75c2e900
  Author: Christopher Orr <ch...@orr.me.uk>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M 
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrackAssignmentBuilderTest.java

  Log Message:
  -----------
  Add static imports for helpers in ReleaseTrackAssignmentBuilderTest.


  Commit: 6d111db814706a6e5969d9bdc2f836dcb5af4a35
      
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/6d111db814706a6e5969d9bdc2f836dcb5af4a35
  Author: Christopher Orr <ch...@orr.me.uk>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M 
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher.java
    M 
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrackAssignmentBuilder.java
    M 
src/main/resources/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher/config.jelly
    M 
src/main/resources/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrackAssignmentBuilder/config.jelly

  Log Message:
  -----------
  Make the default value for percentage appear in config forms.

This makes it consistent with how the files pattern works, i.e. its
default value appears in the job config form, and the Pipeline snippet
generator.

Also made percentage values appear with the %-sign suffix, as it looks
a little bit nicer, and helps further reinfoce that it's a percentage
value and not a fraction, i.e. should be set to '50%' rather than '0.5'.


  Commit: 7cbad316ab970200f3d5dc6fc56c67f3e3223a2c
      
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/7cbad316ab970200f3d5dc6fc56c67f3e3223a2c
  Author: Christopher Orr <ch...@orr.me.uk>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M 
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher.java
    M 
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ReleaseTrackAssignmentBuilder.java

  Log Message:
  -----------
  Expand the lack-of-track-name error message a little.


  Commit: 1e8b5b4c3a31418be45446aa61028b40b04def0d
      
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/1e8b5b4c3a31418be45446aa61028b40b04def0d
  Author: Christopher Orr <ch...@orr.me.uk>
  Date:   2020-05-22 (Fri, 22 May 2020)

  Changed paths:
    M README.md

  Log Message:
  -----------
  Update README for track name breaking change.


Compare: 
https://github.com/jenkinsci/google-play-android-publisher-plugin/compare/c875dafe3ee7%5E...1e8b5b4c3a31

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/google-play-android-publisher-plugin/push/refs/heads/feature/JENKINS-62398_make-track-mandatory/000000-1e8b5b%40github.com.

Reply via email to