Branch: refs/heads/master
Home: https://github.com/jenkinsci/cloudbees-folder-plugin
Commit: 642dc1c50fefbd8b279a8f859cd826c65305b5bc
https://github.com/jenkinsci/cloudbees-folder-plugin/commit/642dc1c50fefbd8b279a8f859cd826c65305b5bc
Author: amuniz <[email protected]>
Date: 2020-06-04 (Thu, 04 Jun 2020)
Changed paths:
M src/test/java/com/cloudbees/hudson/plugins/folder/FolderTest.java
M
src/test/java/com/cloudbees/hudson/plugins/folder/config/AbstractFolderConfigurationTest.java
Log Message:
-----------
This tests are filing when running on the PCT
1. `FolderTest.shouldHaveHealthMetricConfiguredGloballyOnCreation`: is checking
[something](https://github.com/jenkinsci/cloudbees-folder-plugin/blob/2b9443b5c5d72030a92f59e8843c8948022830b5/src/test/java/com/cloudbees/hudson/plugins/folder/FolderTest.java#L420)
which is not necessarily true (it depends on [this
condition](https://github.com/jenkinsci/cloudbees-folder-plugin/blob/ae00f49fc0c6183983d67c799772fd8b9adc0840/src/main/java/com/cloudbees/hudson/plugins/folder/config/AbstractFolderConfiguration.java#L50)).
So I suspect there is a `FolderHealthMetricDescriptor` in the classpath (from
some other plugin) which is returning `null` on
`FolderHealthMetricDescriptor#createDefault` (which is fine).
2.
`AbstractFolderConfigurationTest#shouldBeAbleToRemoveHealthMetricConfiguredGlobally`:
same reason.
Commit: b6443bb52d018775d481b5190a9d2a0856667010
https://github.com/jenkinsci/cloudbees-folder-plugin/commit/b6443bb52d018775d481b5190a9d2a0856667010
Author: Francisco Javier Fernandez
<[email protected]>
Date: 2020-06-04 (Thu, 04 Jun 2020)
Changed paths:
M src/test/java/com/cloudbees/hudson/plugins/folder/FolderTest.java
M
src/test/java/com/cloudbees/hudson/plugins/folder/config/AbstractFolderConfigurationTest.java
Log Message:
-----------
Merge pull request #149 from amuniz/bad-tests
This tests are failing when running on the PCT
Compare:
https://github.com/jenkinsci/cloudbees-folder-plugin/compare/47de187801f6...b6443bb52d01
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/cloudbees-folder-plugin/push/refs/heads/master/47de18-b6443b%40github.com.
