Branch: refs/heads/master Home: https://github.com/jenkinsci/support-core-plugin Commit: 80bd3d3dac5ebebf1ef120b264aa53f5a306c7db https://github.com/jenkinsci/support-core-plugin/commit/80bd3d3dac5ebebf1ef120b264aa53f5a306c7db Author: James Nord <jtn...@users.noreply.github.com> Date: 2021-11-10 (Wed, 10 Nov 2021)
Changed paths: M src/test/java/com/cloudbees/jenkins/support/impl/OtherLogsTest.java Log Message: ----------- Remove more gratuitous use of mocking. There is no need to mock thi code - and removing more statuic mocking is always a good thing. Commit: 90664ead49262f4180f0502a20093d1a54a5202c https://github.com/jenkinsci/support-core-plugin/commit/90664ead49262f4180f0502a20093d1a54a5202c Author: James Nord <jtn...@users.noreply.github.com> Date: 2021-11-11 (Thu, 11 Nov 2021) Changed paths: M src/main/java/com/cloudbees/jenkins/support/impl/NetworkInterfaces.java M src/test/java/com/cloudbees/jenkins/support/impl/NetworkInterfacesTest.java Log Message: ----------- process the NICs in parallel to reduce the wallclock time On windows it is normal to have a lot of NICs (for example my laptop enumerates 58 NICs) it takes 900ms to build the string for this which is outside the time that the callable is allowed to take. Whilst on Unix like systems you will likely have a lot fewer NICs the resulting code may take a bit longer and it relies on the shared fork-join threadpool this is probably still worthwhile. On my System the callable now takes ~390ms which is half the time it did before and under the 500ms that timesout the callable. Commit: 80c3ad0fe002d14d58a6dd8e6e40d2a226cb4620 https://github.com/jenkinsci/support-core-plugin/commit/80c3ad0fe002d14d58a6dd8e6e40d2a226cb4620 Author: James Nord <jtn...@users.noreply.github.com> Date: 2021-11-11 (Thu, 11 Nov 2021) Changed paths: M src/main/java/com/cloudbees/jenkins/support/impl/NetworkInterfaces.java M src/test/java/com/cloudbees/jenkins/support/impl/NetworkInterfacesTest.java Log Message: ----------- remove the timing and extra debugging used to verify the code Commit: 49baa5ffdc493756972c83b9f90138f87ae206ce https://github.com/jenkinsci/support-core-plugin/commit/49baa5ffdc493756972c83b9f90138f87ae206ce Author: James Nord <jtn...@users.noreply.github.com> Date: 2021-11-11 (Thu, 11 Nov 2021) Changed paths: M src/main/java/com/cloudbees/jenkins/support/impl/NetworkInterfaces.java Log Message: ----------- remove extraneous import Commit: 6c23567a8ee35c86212dd8a8c9b24ad9dc2a5a74 https://github.com/jenkinsci/support-core-plugin/commit/6c23567a8ee35c86212dd8a8c9b24ad9dc2a5a74 Author: Allan Burdajewicz <aburdajew...@cloudbees.com> Date: 2021-11-12 (Fri, 12 Nov 2021) Changed paths: M src/main/java/com/cloudbees/jenkins/support/impl/NetworkInterfaces.java M src/test/java/com/cloudbees/jenkins/support/impl/OtherLogsTest.java Log Message: ----------- Merge pull request #317 from jtnord/fix-flaky-tests More performant NIC gatherer and flaky test improvements Compare: https://github.com/jenkinsci/support-core-plugin/compare/63204a5f551d...6c23567a8ee3 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/support-core-plugin/push/refs/heads/master/63204a-6c2356%40github.com.