Branch: refs/heads/master
Home: https://github.com/jenkinsci/github-oauth-plugin
Commit: 238f375f17dbb8461943f568bb003cfe731948aa
https://github.com/jenkinsci/github-oauth-plugin/commit/238f375f17dbb8461943f568bb003cfe731948aa
Author: thecooldrop <[email protected]>
Date: 2021-12-24 (Fri, 24 Dec 2021)
Changed paths:
M src/main/java/org/jenkinsci/plugins/GithubAuthenticationToken.java
A src/main/java/org/jenkinsci/plugins/JenkinsProxyAuthenticator.java
M src/test/java/org/jenkinsci/plugins/GithubAuthenticationTokenTest.java
M
src/test/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACLTest.java
A src/test/java/org/jenkinsci/plugins/JenkinsProxyAuthenticatorTest.java
Log Message:
-----------
Fix usage behind proxies requiring authentication
If we configure the Jenkins controller to be used behind a proxy which requires
authentication, then the plugin becomes unusable. The
reason for that is the fact that configured username and password are not
passed into the HTTP client from the Jenkins configuration.
To reproduce this error do the following:
- Start the Jenkins controller behind a proxy requiring authentication
- Configure the GitHub Authentication plugin
- Clear your browser cookies
- Try to log in
- Observe the login looping due to a missing access token
This commit fixes the issue.
Co-authored-by: Vanio Begic <[email protected]>
Co-authored-by: Basil Crow <[email protected]>
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/github-oauth-plugin/push/refs/heads/master/9b20d4-238f37%40github.com.
