Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/crowd2-plugin
  Commit: 3369b72f7f928facfe51f3c272a2f7fc5169c081
      
https://github.com/jenkinsci/crowd2-plugin/commit/3369b72f7f928facfe51f3c272a2f7fc5169c081
  Author: Pavel Roskin <plros...@gmail.com>
  Date:   2022-08-07 (Sun, 07 Aug 2022)

  Changed paths:
    M src/main/java/de/theit/jenkins/crowd/CrowdSecurityRealm.java
    A src/test/java/de/theit/jenkins/crowd/CrowdSecurityRealmTest.java

  Log Message:
  -----------
  [JENKINS-68708] CrowdSecurityRealm: Prevent trim() calls on null strings

Replace trim() with StringUtils.trimToEmpty(), it trims strings as well
and also converts null to an empty string.

Don't use trim() in the compatibility constructor. Passwords should be
used without trimming. Secret.fromString(null) returns a valid object.

Add unit tests for CrowdSecurityRealm constructors.

Signed-off-by: Pavel Roskin <plros...@gmail.com>


  Commit: 87ae6f32cac1ac4d2247fd9264800ccabe1b6e91
      
https://github.com/jenkinsci/crowd2-plugin/commit/87ae6f32cac1ac4d2247fd9264800ccabe1b6e91
  Author: Bartosz Nowak <9051964+du...@users.noreply.github.com>
  Date:   2022-08-09 (Tue, 09 Aug 2022)

  Changed paths:
    M src/main/java/de/theit/jenkins/crowd/CrowdSecurityRealm.java
    A src/test/java/de/theit/jenkins/crowd/CrowdSecurityRealmTest.java

  Log Message:
  -----------
  Merge pull request #98 from proski/trim-null

[JENKINS-68708] CrowdSecurityRealm: Prevent trim() calls on null strings


Compare: 
https://github.com/jenkinsci/crowd2-plugin/compare/da78b22b225a...87ae6f32cac1

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/crowd2-plugin/push/refs/heads/master/da78b2-87ae6f%40github.com.

Reply via email to