Branch: refs/heads/v4.11.x
Home: https://github.com/jenkinsci/git-plugin
Commit: 136586efc5f020ba1fce3c736f576583e5c032a7
https://github.com/jenkinsci/git-plugin/commit/136586efc5f020ba1fce3c736f576583e5c032a7
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2022-08-23 (Tue, 23 Aug 2022)
Changed paths:
M src/test/java/jenkins/plugins/git/GitUsernamePasswordBindingTest.java
Log Message:
-----------
Avoid command processor expansion of password values
Windows command processor treats '&' as a special character in
command lines. That makes the sample password '&Ampersand&' expand
incorrectly in the test code that was using `echo` on Windows.
Instead of using `echo` to check that the password is being masked,
use the Windows `type` command to display the contents of the auth.txt
file contents.
This simplifies the test case while still checking that the masking
is performed as expected.
Commit: 29578a8f652389e94b0bc99cb65c103c4f4a2f5a
https://github.com/jenkinsci/git-plugin/commit/29578a8f652389e94b0bc99cb65c103c4f4a2f5a
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2022-08-23 (Tue, 23 Aug 2022)
Changed paths:
M src/test/java/jenkins/plugins/git/GitUsernamePasswordBindingTest.java
Log Message:
-----------
Assert GIT_USERNAME is only masked when secret
Previously only asserted for the case that GIT_USERNAME is masked
when it is secret. Safe to also assert that it is not masked
when it is not secret.
Compare:
https://github.com/jenkinsci/git-plugin/compare/25dd3546c396...29578a8f6523
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/git-plugin/push/refs/heads/v4.11.x/25dd35-29578a%40github.com.
