Branch: refs/heads/master
Home: https://github.com/jenkinsci/github-branch-source-plugin
Commit: 6b4afa5e0de677939cda5d3a56f5b7dddba0555a
https://github.com/jenkinsci/github-branch-source-plugin/commit/6b4afa5e0de677939cda5d3a56f5b7dddba0555a
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2022-09-01 (Thu, 01 Sep 2022)
Changed paths:
A
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentialsSnapshotTaker.java
Log Message:
-----------
[JENKINS-69488] do not SnapShot GitHubAppCredentials
The GitHubApp Credentials converts itself when serialized over remoting
to a DelegatingGitHubAppCredentials to support token refresh.
Whilst it would naively be trivial to replace this with an
implenentation in the GitHubAppCredentialsSnapshotTaker that did the
conversion, this causes issues in controller to controller propagation.
When a Snapshot is taken there may or may not be a Channel in place,
however this does not detract from the fact that it is done so
credentials can be held complete
The code could be obtaining the credentials to send to some code but may
be doing it in outside of a specific task (th a remoting channel (e.g. snapshot
a credential, then
obtain a channel from a computer to execute some code). Whilst unlikely
for this specific credential type - it is also a very generic type and
nothing would prevent code from doing this - nor would that code be
incorrect.
Commit: 7ffae8c1bede3019c7a12f54ac992e4ce77d5d42
https://github.com/jenkinsci/github-branch-source-plugin/commit/7ffae8c1bede3019c7a12f54ac992e4ce77d5d42
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2022-09-02 (Fri, 02 Sep 2022)
Changed paths:
M
src/test/java/org/jenkinsci/plugins/github_branch_source/AbstractGitHubWireMockTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/ApiRateLimitCheckerTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystemTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GithubAppCredentialsTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/IgnoreDraftPullRequestFilterTraitTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMRevisionTest.java
Log Message:
-----------
do not extend assert
Commit: e655ec4aa695efab4dd84813b6830858b748ad86
https://github.com/jenkinsci/github-branch-source-plugin/commit/e655ec4aa695efab4dd84813b6830858b748ad86
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2022-09-02 (Fri, 02 Sep 2022)
Changed paths:
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GithubAppCredentialsTest.java
Log Message:
-----------
Restore working unit test
Selectivly reverts part of 609
Commit: 751a870cb17a79d72e4d2a0fe34110a518a4b521
https://github.com/jenkinsci/github-branch-source-plugin/commit/751a870cb17a79d72e4d2a0fe34110a518a4b521
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2022-09-02 (Fri, 02 Sep 2022)
Changed paths:
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GithubAppCredentialsTest.java
Log Message:
-----------
sort all logs by chronological order
Commit: f961f1dc5dcd403a09894ac22b9fd619f11c4f4d
https://github.com/jenkinsci/github-branch-source-plugin/commit/f961f1dc5dcd403a09894ac22b9fd619f11c4f4d
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2022-09-02 (Fri, 02 Sep 2022)
Changed paths:
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GithubAppCredentialsTest.java
Log Message:
-----------
remove stray logging left over from debug
Commit: a45d053c9987a98c5054dee51b6faa60b19cdf5e
https://github.com/jenkinsci/github-branch-source-plugin/commit/a45d053c9987a98c5054dee51b6faa60b19cdf5e
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2022-09-05 (Mon, 05 Sep 2022)
Changed paths:
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GithubAppCredentialsTest.java
Log Message:
-----------
Update
src/test/java/org/jenkinsci/plugins/github_branch_source/GithubAppCredentialsTest.java
Co-authored-by: Jesse Glick <jgl...@cloudbees.com>
Commit: d46793ac4a5701791b6759cdddf907c49b34459a
https://github.com/jenkinsci/github-branch-source-plugin/commit/d46793ac4a5701791b6759cdddf907c49b34459a
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2022-09-06 (Tue, 06 Sep 2022)
Changed paths:
A
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentialsSnapshotTaker.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/AbstractGitHubWireMockTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/ApiRateLimitCheckerTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystemTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/GithubAppCredentialsTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/IgnoreDraftPullRequestFilterTraitTest.java
M
src/test/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMRevisionTest.java
Log Message:
-----------
Merge pull request #616 from jtnord/JENKINS-69488
[JENKINS-69488] do not SnapShot GitHubAppCredentials
Compare:
https://github.com/jenkinsci/github-branch-source-plugin/compare/7618247e672d...d46793ac4a57
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/github-branch-source-plugin/push/refs/heads/master/761824-d46793%40github.com.
