Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/active-directory-plugin
  Commit: a8be7cdd3ba65474a7d40595b1352f3526005800
      
https://github.com/jenkinsci/active-directory-plugin/commit/a8be7cdd3ba65474a7d40595b1352f3526005800
  Author: Basil Crow <[email protected]>
  Date:   2022-12-03 (Sat, 03 Dec 2022)

  Changed paths:
    M pom.xml
    A 
src/test/java/hudson/plugins/active_directory/docker/ActiveDirectoryGenericContainer.java
    M 
src/test/java/hudson/plugins/active_directory/docker/EntoEndUserCacheLookupDisabledTest.java
    M 
src/test/java/hudson/plugins/active_directory/docker/EntoEndUserCacheLookupEnabledTest.java
    M 
src/test/java/hudson/plugins/active_directory/docker/TheFlintstonesTest.java

  Log Message:
  -----------
  Migrate from Docker fixtures to Testcontainers


  Commit: b1f681580b0f42c3d2cb891fe8711ba2af7bfc76
      
https://github.com/jenkinsci/active-directory-plugin/commit/b1f681580b0f42c3d2cb891fe8711ba2af7bfc76
  Author: Basil Crow <[email protected]>
  Date:   2022-12-03 (Sat, 03 Dec 2022)

  Changed paths:
    M 
src/test/java/hudson/plugins/active_directory/docker/ActiveDirectoryGenericContainer.java

  Log Message:
  -----------
  17:46:35  [ERROR] 
hudson.plugins.active_directory.docker.EntoEndUserCacheLookupEnabledTest.testEndtoEndManagerDnCacheDisabled
  Time elapsed: 66.293 s  <<< ERROR!
17:46:35  org.testcontainers.containers.ContainerLaunchException: Container 
startup failed
17:46:35        at 
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349)
17:46:35        at 
org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322)
17:46:35        at 
org.testcontainers.containers.GenericContainer.starting(GenericContainer.java:1094)
17:46:35        at 
org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:28)
17:46:35        at 
org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:618)
17:46:35        at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
17:46:35        at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
17:46:35        at 
java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
17:46:35        at java.base/java.lang.Thread.run(Thread.java:834)
17:46:35  Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry 
limit hit with exception
17:46:35        at 
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
17:46:35        at 
org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334)
17:46:35        ... 8 more
17:46:35  Caused by: org.testcontainers.containers.ContainerLaunchException: 
Could not create/start container
17:46:35        at 
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:542)
17:46:35        at 
org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344)
17:46:35        at 
org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
17:46:35        ... 9 more
17:46:35  Caused by: org.testcontainers.containers.ContainerLaunchException: 
Timed out waiting for container port to open (192.168.0.1 ports: [464, 3268, 
389, 53, 135, 39, 138, 445] should be listening)
17:46:35        at 
org.testcontainers.containers.wait.strategy.HostPortWaitStrategy.waitUntilReady(HostPortWaitStrategy.java:102)
17:46:35        at 
org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52)
17:46:35        at 
org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:953)
17:46:35        at 
org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:485)
17:46:35        ... 11 more


  Commit: b1394a3468695e2aa9310dc78e48888727fc9677
      
https://github.com/jenkinsci/active-directory-plugin/commit/b1394a3468695e2aa9310dc78e48888727fc9677
  Author: James Nord <[email protected]>
  Date:   2022-12-07 (Wed, 07 Dec 2022)

  Changed paths:
    M Jenkinsfile
    M pom.xml
    M src/main/java/hudson/plugins/active_directory/ActiveDirectoryDomain.java
    M 
src/main/java/hudson/plugins/active_directory/ActiveDirectorySecurityRealm.java
    A src/main/java/hudson/plugins/active_directory/DNSUtils.java
    A 
src/test/java/hudson/plugins/active_directory/WindowsAdsiModeUserCacheDisabledIT.java
    R 
src/test/java/hudson/plugins/active_directory/WindowsAdsiModeUserCacheDisabledTest.java
    A 
src/test/java/hudson/plugins/active_directory/WindowsAdsiModeUserCacheEnabledIT.java
    R 
src/test/java/hudson/plugins/active_directory/WindowsAdsiModeUserCacheEnabledTest.java
    M 
src/test/java/hudson/plugins/active_directory/docker/ActiveDirectoryGenericContainer.java
    M 
src/test/java/hudson/plugins/active_directory/docker/EntoEndUserCacheLookupDisabledTest.java
    M 
src/test/java/hudson/plugins/active_directory/docker/EntoEndUserCacheLookupEnabledTest.java
    A src/test/java/hudson/plugins/active_directory/docker/TheFlintstonesIT.java
    M 
src/test/java/hudson/plugins/active_directory/docker/TheFlintstonesTest.java
    M 
src/test/resources/hudson/plugins/active_directory/docker/TheFlintstonesTest/TheFlintstones/Dockerfile

  Log Message:
  -----------
  the majority of the docker tests did not require static ports

Changed the ports to be dynamically assigned and removed the tests from
the IT profile

Added a assume so that tests would be skipped if docker is not available

Adapted production code to be able to override the DNS server used by
JNDI to aid testing.

CHanged the IT profile into 2 profiles
ITs will run the normal tests *and* the IT tests
onlyITs will only run the ITs (making the pipeline faster as we don't
need to run all tests again inside the customer docker.

When running ITs forkCout will be set to 1 to avoid failures due to port
conflicts.

The WindowsAdsi tests have no test run on CI - they require a very
custom windows environment in order to run.


  Commit: c52e93fd0057579f951833f07eac28481a636488
      
https://github.com/jenkinsci/active-directory-plugin/commit/c52e93fd0057579f951833f07eac28481a636488
  Author: James Nord <[email protected]>
  Date:   2022-12-07 (Wed, 07 Dec 2022)

  Changed paths:
    M src/test/java/hudson/plugins/active_directory/docker/TheFlintstonesIT.java

  Log Message:
  -----------
  remove unused test code


  Commit: 4c60b9dc86d731ce651cb812efc1d62356e1ac15
      
https://github.com/jenkinsci/active-directory-plugin/commit/4c60b9dc86d731ce651cb812efc1d62356e1ac15
  Author: James Nord <[email protected]>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M 
src/test/java/hudson/plugins/active_directory/docker/EntoEndUserCacheLookupDisabledTest.java
    M 
src/test/java/hudson/plugins/active_directory/docker/EntoEndUserCacheLookupEnabledTest.java
    A 
src/test/java/hudson/plugins/active_directory/docker/RequireDockerRule.java
    M src/test/java/hudson/plugins/active_directory/docker/TheFlintstonesIT.java
    M 
src/test/java/hudson/plugins/active_directory/docker/TheFlintstonesTest.java

  Log Message:
  -----------
  Introduce RequireDockerRule to correctly skip tests when docker is not present

Also order the rules so that we first check for docker, then build the
container and then start Jenkins.

This avoids the docker building being part of the timeout of the
JenkinsRule leading to build flakyness.


  Commit: 842daef57d84443354adeac4cc69940616efacee
      
https://github.com/jenkinsci/active-directory-plugin/commit/842daef57d84443354adeac4cc69940616efacee
  Author: Felix Belzunce Arcos <[email protected]>
  Date:   2022-12-16 (Fri, 16 Dec 2022)

  Changed paths:
    M Jenkinsfile
    M pom.xml
    M src/main/java/hudson/plugins/active_directory/ActiveDirectoryDomain.java
    M 
src/main/java/hudson/plugins/active_directory/ActiveDirectorySecurityRealm.java
    A src/main/java/hudson/plugins/active_directory/DNSUtils.java
    A 
src/test/java/hudson/plugins/active_directory/WindowsAdsiModeUserCacheDisabledIT.java
    R 
src/test/java/hudson/plugins/active_directory/WindowsAdsiModeUserCacheDisabledTest.java
    A 
src/test/java/hudson/plugins/active_directory/WindowsAdsiModeUserCacheEnabledIT.java
    R 
src/test/java/hudson/plugins/active_directory/WindowsAdsiModeUserCacheEnabledTest.java
    A 
src/test/java/hudson/plugins/active_directory/docker/ActiveDirectoryGenericContainer.java
    M 
src/test/java/hudson/plugins/active_directory/docker/EntoEndUserCacheLookupDisabledTest.java
    M 
src/test/java/hudson/plugins/active_directory/docker/EntoEndUserCacheLookupEnabledTest.java
    A 
src/test/java/hudson/plugins/active_directory/docker/RequireDockerRule.java
    A src/test/java/hudson/plugins/active_directory/docker/TheFlintstonesIT.java
    M 
src/test/java/hudson/plugins/active_directory/docker/TheFlintstonesTest.java
    M 
src/test/resources/hudson/plugins/active_directory/docker/TheFlintstonesTest/TheFlintstones/Dockerfile

  Log Message:
  -----------
  Merge pull request #153 from jtnord/dynamicports

Switch test containers to dynamic ports for non integration tests


Compare: 
https://github.com/jenkinsci/active-directory-plugin/compare/677842aa7274...842daef57d84

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/active-directory-plugin/push/refs/heads/master/677842-842dae%40github.com.

Reply via email to