Branch: refs/heads/master
Home: https://github.com/jenkinsci/acceptance-test-harness
Commit: a231878193d6a6c8806602d48ac8c5cc7e97eca5
https://github.com/jenkinsci/acceptance-test-harness/commit/a231878193d6a6c8806602d48ac8c5cc7e97eca5
Author: James Nord <jtn...@users.noreply.github.com>
Date: 2023-06-14 (Wed, 14 Jun 2023)
Changed paths:
M src/main/java/org/jenkinsci/test/acceptance/FallbackConfig.java
M src/main/java/org/jenkinsci/test/acceptance/recorder/HarRecorder.java
Log Message:
-----------
improve the contract around HARRecording (#1228)
Tidy up the contract around the HAR being recorded and the proxy being created
The proxy was created on the first call to getProxy and every call after
when the har had been recorded for the previous test.
the Fallback config was responsible for updating the proxy with the test
name
This spread the responsibility for the HAR recording between FallbackConfig
and the HarRecorder.
This change moves the initialisation of the har from the FallbackConfig to
the HarRecorder itself, and no longer shuts down the proxy if a test causes
the har to be recorded.
Whilst the Proxy would not be closed, this is the status quo today and it is
terminated when the surefire JVM exists.
So now we will start the proxy only once per surefire JVM.
This could be a candidate for auto-wiring but that is left for a future
change
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/acceptance-test-harness/push/refs/heads/master/3e1d33-a23187%40github.com.
