Branch: refs/heads/master
Home: https://github.com/jenkinsci/active-choices-plugin
Commit: 038f34c7e46bd8e3962900784cf3d0752726f0f9
https://github.com/jenkinsci/active-choices-plugin/commit/038f34c7e46bd8e3962900784cf3d0752726f0f9
Author: Junyeong Yim <[email protected]>
Date: 2023-11-02 (Thu, 02 Nov 2023)
Changed paths:
M src/main/java/org/biouno/unochoice/model/ScriptlerScript.java
Log Message:
-----------
[JENKINS-72105] Fix scriptler script's parameter
Detail
======
- When there is no `parameters`(deprecated param) in `scriptlerScript`,
`parameters` is set with `Collections.emptyMap()`.
And it is not null, so `parameters` and `parameters` in `ScriptlerBuilder`
in `initializeFromDeprecatedProperties` is empty
map and so parameter can't created.
- I tested with snapshot version of scriptler-plugin, but I don't know the new
version of scriptler dependency is mandatory.
So I create commit without pom.xml.
Commit: f90f4eeb8fff2b456403ed256f9e03d976f81f64
https://github.com/jenkinsci/active-choices-plugin/commit/f90f4eeb8fff2b456403ed256f9e03d976f81f64
Author: Bruno P. Kinoshita <[email protected]>
Date: 2023-11-02 (Thu, 02 Nov 2023)
Changed paths:
M src/main/java/org/biouno/unochoice/model/ScriptlerScript.java
Log Message:
-----------
[JENKINS-72105] Switch from deprecated (arrays) to new Scriptler method (list)
Commit: 8a934aae5f0784028b15af35d131cbf2b7bec0d6
https://github.com/jenkinsci/active-choices-plugin/commit/8a934aae5f0784028b15af35d131cbf2b7bec0d6
Author: Bruno P. Kinoshita <[email protected]>
Date: 2023-11-02 (Thu, 02 Nov 2023)
Changed paths:
M src/main/java/org/biouno/unochoice/model/ScriptlerScript.java
Log Message:
-----------
[JENKINS-72105] Remove null check on NotNull annotated method
Commit: c3c7fa6dca7e5c6c6b6a1f4f5404c04d32e5e0ac
https://github.com/jenkinsci/active-choices-plugin/commit/c3c7fa6dca7e5c6c6b6a1f4f5404c04d32e5e0ac
Author: Bruno P. Kinoshita <[email protected]>
Date: 2023-11-02 (Thu, 02 Nov 2023)
Changed paths:
M pom.xml
A
src/test/java/org/biouno/unochoice/issue72105/TestJobDslWithScriptlerScriptWithParameters.java
A src/test/java/org/biouno/unochoice/issue72105/package-info.java
A
src/test/resources/org/biouno/unochoice/issue72105/TestJobDslWithScriptlerScriptWithParameters/test/jobs/job/config.xml
Log Message:
-----------
[JENKINS-72105] Bump bom to 2.387.x-2550.v4ec98c0b_676d, add pipelines and
job-dsl as test dependencies, add unit test to avoid regressions.
Compare:
https://github.com/jenkinsci/active-choices-plugin/compare/ab5b0819c847...c3c7fa6dca7e
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/active-choices-plugin/push/refs/heads/master/ab5b08-c3c7fa%40github.com.
