Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/workflow-plugin
  Commit: 52f407e83490b77ac1962da3e3af341f97f73653
      
https://github.com/jenkinsci/workflow-plugin/commit/52f407e83490b77ac1962da3e3af341f97f73653
  Author: Kohsuke Kawaguchi <[email protected]>
  Date:   2014-11-07 (Fri, 07 Nov 2014)

  Changed paths:
    M cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java

  Log Message:
  -----------
  [JENKINS-25495]

Interrupt newer ones first so that when they form nested structures, the 
interruption happens from inner ones first, as one would expect.


  Commit: 7b232445e054e5f75a40ced08b4ad937ec611a10
      
https://github.com/jenkinsci/workflow-plugin/commit/7b232445e054e5f75a40ced08b4ad937ec611a10
  Author: Kohsuke Kawaguchi <[email protected]>
  Date:   2014-11-07 (Fri, 07 Nov 2014)

  Changed paths:
    M cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java

  Log Message:
  -----------
  [JENKINS-25495]

Sorting thread list by thread ID, which means older threads always come before 
younger threads.


  Commit: b75509423628767531fe5204d6acf1673b6698b3
      
https://github.com/jenkinsci/workflow-plugin/commit/b75509423628767531fe5204d6acf1673b6698b3
  Author: Kohsuke Kawaguchi <[email protected]>
  Date:   2014-11-07 (Fri, 07 Nov 2014)

  Changed paths:
    M cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java

  Log Message:
  -----------
  [FIXED JENKINS-25495]

Only return inner-most StepExecutions.

For quite a while, I explored the option of composing Continuables. That
is, instead of creating a new thread, we should take existing CpsThread
and use that to run the body, which is what one would naturally expect.
But it turns out this is actually tricky, because when the body is done
and we fire BodyInvoker.bodyCallback, that CpsThread isn't marked
finished yet (which probably is a problem of its own, because that means
we are calling these callbacks from CpsVmThread, which we generally
avoid.) This approach also destroys the symmetry between multiple
concurrent bodies and single thread body.

So in the end I came back to the simple approach of just filtering out
what we think is outer StepExecutions by looking at FlowHeads of various
CpsThread.

I'm going to check in my additions in groovy-cps during this experiment.


  Commit: cc174f02d9fbb6fe0892cb2fef54facf05e54119
      
https://github.com/jenkinsci/workflow-plugin/commit/cc174f02d9fbb6fe0892cb2fef54facf05e54119
  Author: CloudBees DEV@Cloud <[email protected]>
  Date:   2014-11-07 (Fri, 07 Nov 2014)

  Changed paths:
    M cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
    M cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java

  Log Message:
  -----------
  Merge commit 'b75509423628767531fe5204d6acf1673b6698b3'


Compare: 
https://github.com/jenkinsci/workflow-plugin/compare/910158950f2a...cc174f02d9fb

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to