Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins-test-harness
Commit: 3b5659834a066c27a991c742649d976b535dc18a
https://github.com/jenkinsci/jenkins-test-harness/commit/3b5659834a066c27a991c742649d976b535dc18a
Author: Vincent Latombe <[email protected]>
Date: 2024-08-13 (Tue, 13 Aug 2024)
Changed paths:
M src/main/java/org/jvnet/hudson/test/TemporaryDirectoryAllocator.java
Log Message:
-----------
Improve exception readability in case a directory can't be deleted because it
still contains files
Use suppressed exceptions rather than wrap the exception so that we get
the primary cause first, then details.
Also resolve files relative to their containing folders.
Before:
```
java.io.IOException: [REDACTED]/target/tmp/j
h16565971146678333138/users/Fred_10744520479289247763/config.xml
at
org.jvnet.hudson.test.TemporaryDirectoryAllocator.delete(TemporaryDirectoryAllocator.java:144)
at
org.jvnet.hudson.test.TemporaryDirectoryAllocator.delete(TemporaryDirectoryAllocator.java:131)
at
org.jvnet.hudson.test.TemporaryDirectoryAllocator.delete(TemporaryDirectoryAllocator.java:131)
at
org.jvnet.hudson.test.TemporaryDirectoryAllocator.dispose(TemporaryDirectoryAllocator.java:99)
at
org.jvnet.hudson.test.TestEnvironment.dispose(TestEnvironment.java:84)
at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:527)
at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:665)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.nio.file.DirectoryNotEmptyException: [REDACTED]/target/tmp/j
h16565971146678333138/users/Fred_10744520479289247763
at
java.base/sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:246)
at
java.base/sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:110)
at java.base/java.nio.file.Files.deleteIfExists(Files.java:1191)
at
org.jvnet.hudson.test.TemporaryDirectoryAllocator.delete(TemporaryDirectoryAllocator.java:141)
... 8 more
```
After:
```
java.nio.file.DirectoryNotEmptyException: [REDACTED]/target/tmp/j
h16565971146678333138/users/Fred_10744520479289247763
at
java.base/sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:289)
at
java.base/sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:109)
at java.base/java.nio.file.Files.deleteIfExists(Files.java:1191)
at
org.jvnet.hudson.test.TemporaryDirectoryAllocator.delete(TemporaryDirectoryAllocator.java:142)
at
org.jvnet.hudson.test.TemporaryDirectoryAllocator.dispose(TemporaryDirectoryAllocator.java:100)
at
org.jvnet.hudson.test.TestEnvironment.dispose(TestEnvironment.java:84)
at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:586)
at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:724)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at java.base/java.lang.Thread.run(Thread.java:1583)
Suppressed: java.io.IOException: These files still exist : config.xml
at
org.jvnet.hudson.test.TemporaryDirectoryAllocator.delete(TemporaryDirectoryAllocator.java:146)
... 6 more
```
Commit: cff7ad4969e511270b1c14d1f3c2c3c71034aaf7
https://github.com/jenkinsci/jenkins-test-harness/commit/cff7ad4969e511270b1c14d1f3c2c3c71034aaf7
Author: Jesse Glick <[email protected]>
Date: 2024-08-13 (Tue, 13 Aug 2024)
Changed paths:
M src/main/java/org/jvnet/hudson/test/TemporaryDirectoryAllocator.java
Log Message:
-----------
Merge pull request #814 from Vlatombe/delete-diagnostics
Improve exception readability in case a directory can't be deleted because it
still contains files
Compare:
https://github.com/jenkinsci/jenkins-test-harness/compare/c5074105d9c8...cff7ad4969e5
To unsubscribe from these emails, change your notification settings at
https://github.com/jenkinsci/jenkins-test-harness/settings/notifications
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jenkins-test-harness/push/refs/heads/master/c50741-cff7ad%40github.com.
