Branch: refs/heads/credentials-upload
Home: https://github.com/jenkinsci/credentials-plugin
Commit: f4dbb2b39e9ed399dfd0b5907bc13d62c019b60f
https://github.com/jenkinsci/credentials-plugin/commit/f4dbb2b39e9ed399dfd0b5907bc13d62c019b60f
Author: Jesse Glick <[email protected]>
Date: 2015-01-13 (Tue, 13 Jan 2015)
Changed paths:
M
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Log Message:
-----------
toCharArray can return null (never an empty array), yet you cannot pass null
to KeyStore.getKey.
It will throw a NullPointerException, not an UnrecoverableEntryException.
This caused an ugly stack trace to be shown when the password was not available
to form validation.
Could retrieve key "1". You may need to provide a password
java.security.UnrecoverableKeyException: Get Key failed: null
at
sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:295)
at java.security.KeyStore.getKey(KeyStore.java:792)
at
com.cloudbees.plugins.credentials.impl.CertificateCredentialsImpl$KeyStoreSourceDescriptor.validateCertificateKeystore(CertificateCredentialsImpl.java:224)
at
com.cloudbees.plugins.credentials.impl.CertificateCredentialsImpl$FileOnMasterKeyStoreSource$DescriptorImpl.doCheckKeyStoreFile(CertificateCredentialsImpl.java:333)
at …
Caused by: java.lang.NullPointerException
at
sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:269)
... 69 more
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
