Branch: refs/heads/JENKINS-71909
Home: https://github.com/jenkinsci/active-choices-plugin
Commit: a29fad62987a139735d62aecbaa107e2f878e968
https://github.com/jenkinsci/active-choices-plugin/commit/a29fad62987a139735d62aecbaa107e2f878e968
Author: Bruno P. Kinoshita <[email protected]>
Date: 2024-09-28 (Sat, 28 Sep 2024)
Changed paths:
M package.json
M pom.xml
M src/main/resources/org/biouno/unochoice/CascadeChoiceParameter/index.jelly
M
src/main/resources/org/biouno/unochoice/DynamicReferenceParameter/index.jelly
M src/main/resources/org/biouno/unochoice/stapler/unochoice/UnoChoice.es6
M src/test/java/org/biouno/unochoice/UiAcceptanceTest.java
M webpack.config.js
Log Message:
-----------
[JENKINS-71909]: Revert
https://github.com/jenkinsci/active-choices-plugin/pull/79
The merge request mentions JENKINS-71365 (prototype.JS is removed from Jenkins
core)
but reverting this should not impact that.
What we are doing is removing the async calls and promises, and instead using
the
synchronous code again. This is so that Active Choices parameters are rendering
in
order as they were before.
Whilst rendering them asynchronously seemed like a good idea to provide a more
responsive UI, in reality we oversaw an important aspect: users write their
scripts
relying on the order parameters are loaded.
Users wrote their code using document.getElementId, for instance, which worked
previously
as users would put the parameter doing that after the parameter from which the
ID was
being used.
There were several issues rendered, so this is not likely to be added back again
any time soon. In order to have a more smart reactivity, we would need places
to hook
user callback code (like Vue or React do), but provided by Jenkins UI, or in a
way
that could take some time to create in the plug-in without breaking things, and
that
works well.
Commit: cdd60248fe8ed2d58ef883da5fae701b71e2bd93
https://github.com/jenkinsci/active-choices-plugin/commit/cdd60248fe8ed2d58ef883da5fae701b71e2bd93
Author: Bruno P. Kinoshita <[email protected]>
Date: 2024-09-28 (Sat, 28 Sep 2024)
Changed paths:
M src/main/resources/org/biouno/unochoice/stapler/unochoice/UnoChoice.es6
Log Message:
-----------
Replace Ajax (prototype) by pure JS call to XMLHttpRequest
Commit: f724f97e1208ec93474dca8b43d566ad734880ac
https://github.com/jenkinsci/active-choices-plugin/commit/f724f97e1208ec93474dca8b43d566ad734880ac
Author: Bruno P. Kinoshita <[email protected]>
Date: 2024-09-28 (Sat, 28 Sep 2024)
Changed paths:
M src/main/resources/org/biouno/unochoice/stapler/unochoice/UnoChoice.es6
Log Message:
-----------
WIP @asc3ns10n's suggestions
Commit: f39cba27a5637a2accad9b98fea80b3c48f67327
https://github.com/jenkinsci/active-choices-plugin/commit/f39cba27a5637a2accad9b98fea80b3c48f67327
Author: Bruno P. Kinoshita <[email protected]>
Date: 2024-09-28 (Sat, 28 Sep 2024)
Changed paths:
M src/main/resources/org/biouno/unochoice/stapler/unochoice/UnoChoice.es6
Log Message:
-----------
WIP awaiting the proxy methods now...
Commit: 8a583b2b5056d0def5f5c8752ce490e251ced627
https://github.com/jenkinsci/active-choices-plugin/commit/8a583b2b5056d0def5f5c8752ce490e251ced627
Author: Bruno P. Kinoshita <[email protected]>
Date: 2024-09-28 (Sat, 28 Sep 2024)
Changed paths:
M
src/main/resources/org/biouno/unochoice/CascadeChoiceParameter/config.jelly
M src/main/resources/org/biouno/unochoice/ChoiceParameter/config.jelly
M
src/main/resources/org/biouno/unochoice/DynamicReferenceParameter/config.jelly
M src/main/resources/org/biouno/unochoice/model/ScriptlerScript/config.jelly
Log Message:
-----------
Update help URL
Commit: ee32b3ec3a0a314bc30a3647f80a84fad43f66ed
https://github.com/jenkinsci/active-choices-plugin/commit/ee32b3ec3a0a314bc30a3647f80a84fad43f66ed
Author: Bruno P. Kinoshita <[email protected]>
Date: 2024-09-28 (Sat, 28 Sep 2024)
Changed paths:
M src/test/java/org/biouno/unochoice/UiAcceptanceTest.java
Log Message:
-----------
Fix Selenium issue when clicking help icon
Commit: 506ea3c933db3be8c0cc85556f53f4b885f48242
https://github.com/jenkinsci/active-choices-plugin/commit/506ea3c933db3be8c0cc85556f53f4b885f48242
Author: Bruno P. Kinoshita <[email protected]>
Date: 2024-09-28 (Sat, 28 Sep 2024)
Changed paths:
M src/main/resources/org/biouno/unochoice/common/radioContent.jelly
Log Message:
-----------
$id is not defined, so replicate as in checkbox.jelly the set id from jelly
Commit: 7f8c60e2a1ecd365501f67c3425d75cc92cc9ac7
https://github.com/jenkinsci/active-choices-plugin/commit/7f8c60e2a1ecd365501f67c3425d75cc92cc9ac7
Author: Bruno P. Kinoshita <[email protected]>
Date: 2024-09-28 (Sat, 28 Sep 2024)
Changed paths:
M
src/test/java/org/biouno/unochoice/issue62835/TestForNodeLabelParameter.java
Log Message:
-----------
Close webclient try-with-resources
Compare:
https://github.com/jenkinsci/active-choices-plugin/compare/4ec716aae953...7f8c60e2a1ec
To unsubscribe from these emails, change your notification settings at
https://github.com/jenkinsci/active-choices-plugin/settings/notifications
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/active-choices-plugin/push/refs/heads/JENKINS-71909/4ec716-7f8c60%40github.com.
