Branch: refs/heads/master
Home: https://github.com/jenkinsci/active-choices-plugin
Commit: 3e30ea2de1768ffe8a01e136710d63ecff8cb3f9
https://github.com/jenkinsci/active-choices-plugin/commit/3e30ea2de1768ffe8a01e136710d63ecff8cb3f9
Author: Bruno P. Kinoshita <[email protected]>
Date: 2024-10-06 (Sun, 06 Oct 2024)
Changed paths:
M CHANGES.md
M pom.xml
M
src/main/resources/org/biouno/unochoice/CascadeChoiceParameter/config.jelly
M src/main/resources/org/biouno/unochoice/CascadeChoiceParameter/index.jelly
M src/main/resources/org/biouno/unochoice/ChoiceParameter/config.jelly
M
src/main/resources/org/biouno/unochoice/DynamicReferenceParameter/config.jelly
M
src/main/resources/org/biouno/unochoice/DynamicReferenceParameter/index.jelly
M src/main/resources/org/biouno/unochoice/common/radioContent.jelly
M src/main/resources/org/biouno/unochoice/model/ScriptlerScript/config.jelly
M src/main/resources/org/biouno/unochoice/stapler/unochoice/UnoChoice.es6
A src/test/java/org/biouno/unochoice/BaseUiTest.java
M src/test/java/org/biouno/unochoice/UiAcceptanceTest.java
M
src/test/java/org/biouno/unochoice/issue62835/TestForNodeLabelParameter.java
A
src/test/java/org/biouno/unochoice/issue71909/TestRevertingAsynchronousProxy.java
A src/test/java/org/biouno/unochoice/issue71909/package-info.java
A
src/test/resources/org/biouno/unochoice/issue71909/TestRevertingAsynchronousProxy/test/jobs/test/config.xml
Log Message:
-----------
[JENKINS-71909]: Revert
https://github.com/jenkinsci/active-choices-plugin/pull/79
The merge request mentions JENKINS-71365 (prototype.JS is removed from Jenkins
core)
but reverting this should not impact that.
What we are doing is removing the async calls and promises, and instead using
the
synchronous code again. This is so that Active Choices parameters are rendering
in
order as they were before.
Whilst rendering them asynchronously seemed like a good idea to provide a more
responsive UI, in reality we oversaw an important aspect: users write their
scripts
relying on the order parameters are loaded.
Users wrote their code using document.getElementId, for instance, which worked
previously
as users would put the parameter doing that after the parameter from which the
ID was
being used.
There were several issues rendered, so this is not likely to be added back again
any time soon. In order to have a more smart reactivity, we would need places
to hook
user callback code (like Vue or React do), but provided by Jenkins UI, or in a
way
that could take some time to create in the plug-in without breaking things, and
that
works well.
To unsubscribe from these emails, change your notification settings at
https://github.com/jenkinsci/active-choices-plugin/settings/notifications
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/active-choices-plugin/push/refs/heads/master/f957e5-3e30ea%40github.com.
