Branch: refs/heads/secret-step
Home: https://github.com/jenkinsci/pipeline-model-definition-plugin
Commit: f25d40a2a5ffe0469ce80b070610d07fcdd3bb2a
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/f25d40a2a5ffe0469ce80b070610d07fcdd3bb2a
Author: Andrew Bayer <[email protected]>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java
A
pipeline-model-definition/src/test/resources/errors/pipelineStepWithinOtherBlocksFailure.groovy
Log Message:
-----------
[FIXED JENKINS-39011] Error out at parse time when pipeline step is nested.
We don't want to support nesting the pipeline step within other blocks
- until JENKINS-38152, we never noticed that this was actually
possible, since the parse-time validation just ignored any Jenkinsfile
without a root-level pipeline step, but with JENKINS-38152, we not
only do another parse round but need to grab the stages from the model
to attach to the run, so we hit an NPE when there's a pipeline step
nested under other blocks.
So - this will now catch when the pipeline step is nested within
another block and give an error message at parse-time, rather than
NPEing at runtime. There is a valid use case for wanting to wrap the
entire build in something like a timeout or timestamper, but we're
going to address that with JENKINS-37823.
Commit: 4c9cb6df95d606dc02bf747d91f6e0e00f2ee4f6
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/4c9cb6df95d606dc02bf747d91f6e0e00f2ee4f6
Author: Andrew Bayer <[email protected]>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java
A
pipeline-model-definition/src/test/resources/errors/pipelineStepWithinOtherBlocksFailure.groovy
Log Message:
-----------
Merge pull request #33 from abayer/jenkins-39011
[FIXED JENKINS-39011] Error out at parse time when pipeline step is n…
Commit: 5cec3c6110efc0c1ff793a3468e5f9adc1f4f708
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/5cec3c6110efc0c1ff793a3468e5f9adc1f4f708
Author: Andrew Bayer <[email protected]>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java
A
pipeline-model-definition/src/test/resources/errors/pipelineStepWithinOtherBlocksFailure.groovy
Log Message:
-----------
Merge branch 'master' into secret-step
Compare:
https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/195c6371c009...5cec3c6110ef
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
