Erick,

Here is the ticket:
https://issues.jenkins-ci.org/browse/JENKINS-12828

I can take a look at adding semicolon delimited support while still
supporting comma delimited lists.

Matt

On Sat, Feb 18, 2012 at 8:53 PM, Erick Dovale <[email protected]> wrote:
> Matt,
> You are right that cfn-create-stack takes a semicolon delimited list.
> This is were you would fix
> it: https://github.com/jenkinsci/jenkins-cloudformation-plugin/blob/master/src/main/java/com/syncapse/jenkinsci/plugins/awscloudformationwrapper/StackBean.java#L114
>
> Let me know if intend on sending a pull request or if you want me to fix it.
> I'd also appreciate if you opened a jira ticket with an explanation of the
> problem.
>
> Thanks.
>
> Erick.
>
>
> On Fri, Feb 17, 2012 at 12:10 PM, Matt Fair <[email protected]> wrote:
>>
>> Erick,
>> I agree with you on backwards compatibility.  I think you should be
>> able to first check for semicolons and if there are none, then use
>> commas as the delimiter.  CommaDelimitedList values are usually used
>> when you are specifying availability zones as a group.  I ran across
>> it when I was setting up a RDS in my VPC, I had no problem testing my
>> configuration at the command line because cfn-create-stack uses
>> semicolon delimited lists.
>> Where in the code would this change be made?
>> Matt
>>
>> On Fri, Feb 17, 2012 at 7:57 AM, Erick Dovale <[email protected]> wrote:
>> >
>> > Hi Matt,
>> > That’s an interesting request. I think it is possible but I am concerned
>> > with backwards compatibility. If we just change the plugin to use
>> > semicolons
>> > this will be a breaking change for all installations out there.
>> > What kind of information are you passing to CF as csv? Is it possible
>> > for
>> > you to use something else?
>> >
>> > Thanks.
>> >
>> > Erick.
>> >
>> >
>> > On 12-02-17 1:44 AM, "Matt Fair" <[email protected]> wrote:
>> >
>> > Erick,
>> > I've been using the CloudFormation plugin you are maintaining and I
>> > have  a parameter that is a CommaDelimitedList type.  This is a
>> > problem however because the parameter list is also comma delimitated,
>> > so there is no way to delineate between my parameter value and my
>> > list.  I tried adding quotes with no luck to separate my list.  Is it
>> > possible to have the parameter key/value list be separated by
>> > semicolons instead of commas to allow for CommaDelimitedList type
>> > parameters?
>> > Thanks,
>> > Matt
>> >
>
>

Reply via email to