I also think this is a buggy feature - assuming the use case you suggest is a feature. Moving author -> user creation to GitChangeSet constructor makes sense, and will mostly preserve this use case afaik
2012/3/16 Mirko Friedenhagen <[email protected]> > Maybe this is a mechanism to allow overriding the email address in > Jenkins? When starting with git, some people "forget" to set their > correct email adress, so it is automatically set to > LOCALUSER@WORKSTATIO_NAME. You may then easily override this with the > correct email address in the people folder. > > Regards Mirko > > > On Fri, Mar 16, 2012 at 20:23, Andrew Bayer <[email protected]> > wrote: > > Yeah, that sounds like a bug to me. > > > > A. > > > > > > On Fri, Mar 16, 2012 at 10:04 AM, Ryan Campbell <[email protected] > > > > wrote: > >> > >> I just tried to load (maybe you shouldn't click it) http > >> ://ci.jenkins-ci.org/people and I got this error: > >> > >> 504 Gateway Time-out > >> > >> The server didn't respond in time. > >> > >> I've seen similar problems on our own Jenkins (causing 100% CPU > >> usage), with threads hanging like so: > >> https://gist.github.com/00db0f6d7e48e1f4bf02 > >> > >> This points to the code in GitChangeSet.getAuthor: > >> > >> > https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitChangeSet.java#L254 > >> > >> I don't understand why we want persistent users created in our user > >> database just because they committed to a project we happen to be > >> building. And I especially don't understand why we'd want to do this > >> in a *get* method which one would expect to be side-effect free. > >> > >> It seems to me that the resolution (and creation) of the Author's User > >> should be done in the constructor of the GitChangeSet, no? This will > >> be more in line with how the SVN and CVS plugins work, and transfers > >> the user-creation work to the build time instead of page-loading time. > >> > >> Thanks, > >> Ryan > > > > >
