Hello Jenkiners, Based on John's patch pull request on GitHub has been created. https://github.com/jenkinsci/jenkins/pull/487 It would be nice if some of you can have a look and provide feedback if required in order to get it accepted for core.
br Dharmesh On Friday, May 25, 2012 9:15:45 AM UTC+2, Dharmesh sheta wrote: > > Anybody else can review this patch? > > > > On Tuesday, May 15, 2012 5:54:33 PM UTC+2, John wrote: >> >> I've filed https://issues.jenkins-ci.org/browse/JENKINS-13742 for this >> defect, but not sure the auto-assign gave it to a Jenkins core >> developer, and I don't want to change the assignment without someone >> first agreeing to take it. More details are in the artifact, but I'll >> give a brief summary here. Assume you have a post-build action with >> the following fields and parent elements (parent might be div or >> table): >> >> <parent name="publisher"> >> <parent name="connectionFactory"> >> <input name="url"/> >> <input name="username"/> >> <input name="password"/> >> </parent> >> <input name="project"/> >> </parent> >> >> The field validation for "project" needs the values of url, username, >> and password and the generated javascript does include calls to >> "nearBy" for each of those fields. But since project has a different >> parent, nearBy fails to find the dependency fields. >> >> In the artifact, I present a solution that allows "nearBy" to find the >> nested fields so that if "project" has parent "publisher", then fields >> who have the "publisher" element as any ancestor (in this case >> grandparent), satisfy the nearBy requirement. >> >> So can someone review the artifact/patch and give some guidance. >> Thank you, >> John McNally > >
