Hi all, I'm looking at fixing JENKINS-14278[1] on the parameterized-trigger plugin.
I think I have fixed the issue, and I wrote tests that show the issues before making the changes. Testcases commited at [2] Code Fixes at [3] However once making the changes to the plugin the test case still fails, in a different way. Before the fix the test case failed with the java.lang.IllegalArgumentException as per the error report, after the fix the test case just hung and never completed. The test case involves a matrix project being configured to call builds on other projects while waiting for them to finish this gives the following build chain Matrix parent -> Matrix child (triggers+block) -> Project1 Debugging through this shows that the Project1 never get called to run, which causes the parameterized-trigger to hang while waiting for the the build to finish at Future.get() in BlockableBuildTriggerConfig.[4] If the test is configured to not block, the Matrix child builds complete and indicate that the subjobs were triggered, but the logs do not show them every running. To see if this hang was related to the MatrixProject, I also created a test case where a build triggers another one which also triggers others . ProjectA (triggers+block) -> ProjectB (triggers+block) -> ProjectC. The same error ocurs in this case ProjectC does not seem to run, and also hangs at Future.get()[4] So this looks like an issue in the test case running. The issue is not "no free executors" as i have increased that to greater than the total combination of builds. Can anyone see why the second level of jobs is not running in the test harness? as when creating the jobs on a proper Jenkins instance they work with no issues at all. [1]https://issues.jenkins-ci.org/browse/JENKINS-14278 [2] https://github.com/cjo9900/parameterized-trigger-plugin/commit/f26766b3eca5ebdd3388b1a0ba2fdb86c338c9fc [3] https://github.com/cjo9900/parameterized-trigger-plugin/commit/ca9992f8110aa6991dd013e4f7100fee229bf92d [4] https://github.com/cjo9900/parameterized-trigger-plugin/blob/JENKINS-14278/src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java#L115 Thanks for any help on this. Chris.
